Fix spelling error in Logo component acronym attribute#179
Open
DeveloperBatuhanALGUL wants to merge 1 commit into
Open
Fix spelling error in Logo component acronym attribute#179DeveloperBatuhanALGUL wants to merge 1 commit into
DeveloperBatuhanALGUL wants to merge 1 commit into
Conversation
The Logo component exposed an attribute named 'accronym' (double c), which is a misspelling of 'acronym'. Closes swiss#30. This adds a new 'acronym' prop alongside the existing 'accronym' prop. A computed value (acronymValue) reads the new prop first and falls back to the old one, so existing consumers passing accronym keep working unchanged. Internal usages in TopHeader.vue and Logo.stories.js are updated to use the corrected 'acronym' name. The old 'accronym' prop is left in place, deprecated but functional, to avoid a breaking change for any external site already using this component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30.
The Logo component's
accronymattribute is misspelled (should beacronym, no double c).This PR adds a new
acronymprop alongside the existingaccronymprop, with a computed fallback (acronymValue) that prefers the new name but falls back to the old one. This avoids a breaking change for any site already using the misspelled attribute.Internal usages (
TopHeader.vue,Logo.stories.js) are updated to the corrected name.Verified with
nuxi typecheckandeslint— no new errors introduced (pre-existing unrelated type errors in other files are untouched).