breaking: move adapter to vite.config.ts#15837
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: a8198a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
teemingc
reviewed
May 15, 2026
teemingc
reviewed
May 15, 2026
teemingc
approved these changes
May 15, 2026
Member
There was a problem hiding this comment.
I've looked through the changes, comparing them with the changes in #15780 and #15574 . Looks good. I've commented on just two things that were missing. The svelte.dev deployment also builds successfully after I moved the adapter to the Vite config https://vercel.com/svelte/svelte-dev/GP8NKd3kTLEYi4nEob8AUQSQgE4P
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
…apter-vite-config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15574 has become somewhat overwhelming; thought I might experiment with extracting some of the changes into more manageable PRs that are useful independently of the env API stuff.
This PR moves the
adapteroption fromsvelte.config.jstovite.config.ts. This is valuable in its own right, since it makes it possible for adapters to include their own Vite plugins, without the need to awkwardly hack around the timing of config resolution (for example, you could imagine an adapter providing platform-specific routes in dev/preview). That part isn't implemented in this PR though, that can be a follow-up — for now, it just moves the option.Draft because I had Opus do the work, and I haven't yet looked closely at the diff (either against
version-3, or againstfetchable-dev-environment)