feat: fetchable dev environments#15574
Conversation
🦋 Changeset detectedLatest commit: b6389f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
|
I wonder if we should break this PR into smaller chunks so that it's a bit more reviewable — at the moment it's quite overwhelming. Started here: #15837 |
|
Yeah, agreed. Merging the stacked PR was my mistake because that made this PR include all the changed files from that. I'll try to split the rest into something like:
EDIT: the PR is already looking smaller and will be smaller once the PRs above are merged. Going to hold off on splitting it up more for the moment |
#15574 has become somewhat overwhelming; thought I might experiment with extracting some of the changes into more manageable PRs that are useful independently of the env API stuff. This PR moves the `adapter` option from `svelte.config.js` to `vite.config.ts`. This is valuable in its own right, since it makes it possible for adapters to include their own Vite plugins, without the need to awkwardly hack around the timing of config resolution (for example, you could imagine an adapter providing platform-specific routes in dev/preview). That part isn't implemented in this PR though, that can be a follow-up — for now, it just moves the option. Draft because I had Opus do the work, and I haven't yet looked closely at the diff (either against `version-3`, or against `fetchable-dev-environment`) --------- Co-authored-by: Tee Ming <chewteeming01@gmail.com>
| timeout | ||
| }), | ||
| `Error: The entries export from /[slug]/[notSpecific] generated entry /whatever/specific, which was matched by /[slug]/specific - see the \`handleEntryGeneratorMismatch\` option in https://svelte.dev/docs/kit/configuration#prerender for more info.${EOL}To suppress or handle this error, implement \`handleEntryGeneratorMismatch\` in https://svelte.dev/docs/kit/configuration#prerender` | ||
| /Error: The entries export from \/\[slug\]\/\[notSpecific\] generated entry \/whatever\/specific, which was matched by \/\[slug\]\/specific - see the `handleEntryGeneratorMismatch` option in https:\/\/svelte\.dev\/docs\/kit\/configuration#prerender for more info\.\r?\nTo suppress or handle this error, implement `handleEntryGeneratorMismatch` in https:\/\/svelte\.dev\/docs\/kit\/configuration#prerender/ |
There was a problem hiding this comment.
Changes the assertion from an exact string match to an includes type of match. This is needed because throwing the error from the environment includes some additional details before the expected message
splitting out changes from #15574 This PR creates and moves some utils to be Node-agnostic so that we can use them to resolve paths in the dev environment --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [ ] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
split out from #15574 This PR replaces our use of [`als.enterWith`](https://nodejs.org/api/async_context.html#asynclocalstorageenterwithstore) with the standard `als.run` because `enterWith` is not standard in other runtimes such as workerd (it's an experimental node feature). This change requires wrapping our server response code in a function and running async local storage with that function --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [ ] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
| } | ||
|
|
||
| if (__SVELTEKIT_DEV__ && typeof error == 'object') { | ||
| fix_stack_trace(error); |
There was a problem hiding this comment.
AFAIK there's no need to fix stack traces inside environments as Vite handles that
| @@ -0,0 +1,3 @@ | |||
| declare module '__SERVER__/index.js' { | |||
There was a problem hiding this comment.
helps avoids a type error when importing this in the prerender_entry.js file
| serve_static_middleware.handle(req, res, () => { | ||
| void setResponse(res, rendered); | ||
| // fallback to our own fetch handler if the adapter doesn't provide one | ||
| if (!adapter?.vite?.plugins) { |
There was a problem hiding this comment.
Might be better to add adapter config options such as adapter.vite.customDev and adapter.vite.customPreview which default to false and can be set to true to disable the default SSR handlers during vite dev and vite preview
This PR changes the dev, preview, build analysis and prerender to run inside of the configured Vite SSR environment. This required the following fundamental changes:
1. Avoiding Node.js imports in the runtime
node:fsis a requirement but we import it in the main process instead and communicate the results back to the Vite SSR environment.AsyncLocalStorage.enterWithbecause it's a Node.js-only experimental API2. Replacing Vite's
ssrLoadModuleThe Vite docs recommendation is to create a
ModuleRunneror theRunnableDevEnvironmentinstance to achieve a similar functionality but these don't work with Cloudflare's environment. There's also no strict contract for environments to make these available to us so they can't be relied on. We solve this in two different ways:import.meta.hot.onin the SSR environment to listen for events from the main process, compute the result, and send it back.Serverclass from the build output in the main process, we spin up a Vite development server with the build output but proxy theServerclass by intercepting module resolution with Vite'sresolveIdhook. Starting a dev server and sending a request or HMR event seems to be the only way to run a module in the environment.3. Communication between the main process (where Vite runs) and the SSR environment (where user code runs)
The two points before this makes this a requirement. Now we'll detail the different types of communication that exist as a result:
One way communication
environments.ssr.hot.send. This helps us retain synchronous access to the filesystem from a non-Node environment such as checking if a filename exists as a key in the server assets map. We can also construct virtual modules with serialised data that the can be imported and accessed in the environment.import.meta.hot.sendso that the main process can then create a Vite error overlay in the browser. This replaces ourloudSsrLoadModuleutility.Two way communication
ssrLoadModuleto run some code in Vite's pipeline and get a result back. Now, we have to ensure the SSR environment has animport.meta.hot.onevent listener attached, emit an event, compute in the environment, and receive the results back in the main process throughenvironments.ssr.hot.onandPromise.withResolversto await the result. This is used for retrieving remote function info, etc. Alternatively, we can also proxy theServerclass during analysis and prerendering to respond with our environment computed result as mentioned earlier.import.meta.hotapproach above because Cloudflare's workerd doesn't like responding to requests from a context created byimport.meta.hot.on. Therefore, we usefetchto send a request to the running Vite dev server, configure the Vite dev server using theconfigureServerhook to intercept the request viavite.middlewares.use, and respond with the computed result. This is primarily used for getting CSS to inline to avoid FOUC during dev, finding out which param matchers exist from the filesystem, or even checking if a feature should be allowed by theadapter.supportsfunction which we can't serialise.Most of the
import.meta.hotandfetchstyle communication requires serialising and deserialising data usingdevalue.Future PRs
sirvon the build output instead of running the SSR serverPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits