feat(circuit_params): report multiverifier component sizes#404
Conversation
PR SummaryLow Risk Overview Leaf sizes are still emitted for every trace log size in the requested range under a Workspace deps add Reviewed by Cursor Bugbot for commit 14dc54d. Bugbot is set up for automated code reviews on this repo. Configure here. |
825649b to
6c7c96b
Compare
af6b3f2 to
18cadb3
Compare
18cadb3 to
55f1397
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 67.58% 67.85% +0.26%
==========================================
Files 42 42
Lines 5411 5456 +45
==========================================
+ Hits 3657 3702 +45
Misses 1754 1754
🚀 New features to boost your workflow:
|
6c7c96b to
ce5906e
Compare
55f1397 to
01b124d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 01b124d. Configure here.
01b124d to
b763425
Compare
ce5906e to
2cb3b4d
Compare
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
@ilyalesokhin-starkware resolved 1 discussion.
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on YairVaknin-starkware).
2cb3b4d to
f546396
Compare
b763425 to
17cb051
Compare
YairVaknin-starkware
left a comment
There was a problem hiding this comment.
@YairVaknin-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ilyalesokhin-starkware).
crates/circuit_params/src/main.rs line 140 at r4 (raw file):
let preprocessed_column_log_sizes = preprocessed_leaf.preprocessed_trace.log_sizes(); // `ProofConfig` expects the components in ascending log-size order.
Where is this enforced?
Code quote:
/ `ProofConfig` expects the components in ascending log-size order.17cb051 to
dcc249a
Compare
f546396 to
764b6fb
Compare
Report the multiverifier circuit's per-component sizes alongside the leaf verifier's. The leaf verifier is reported for every trace log size in the range; the multiverifier (which verifies two proofs of the leaf circuit) is built once from the leaf at max_trace_log_size. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dcc249a to
14dc54d
Compare
|
Previously, YairVaknin-starkware wrote…
It is not enforced directly. |
Merge activity
|


Type
Description
Breaking changes?
This change is