feat(circuit_params): add --registry JSON output#399
feat(circuit_params): add --registry JSON output#399ilyalesokhin-starkware wants to merge 1 commit into
Conversation
PR SummaryMedium Risk Overview
CLI flags are aligned to explicit snake_case names ( Reviewed by Cursor Bugbot for commit 5b7057f. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 67.86% 68.49% +0.62%
==========================================
Files 42 43 +1
Lines 5459 5568 +109
==========================================
+ Hits 3705 3814 +109
Misses 1754 1754
🚀 New features to boost your workflow:
|
8ef2659 to
e71f1b1
Compare
3c6bbf9 to
af6b3f2
Compare
af6b3f2 to
01b124d
Compare
e71f1b1 to
844c983
Compare
844c983 to
feeb45f
Compare
01b124d to
17cb051
Compare
dcc249a to
14dc54d
Compare
feeb45f to
202c191
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 202c191. Configure here.
202c191 to
e56d901
Compare
14dc54d to
705ad6a
Compare
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
@ilyalesokhin-starkware resolved 1 discussion.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on YairVaknin-starkware).
d307560 to
9a6569d
Compare
The JSON schema lives in a new `circuit-registry` crate so it can be shared with the leaf prover. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
9a6569d to
5b7057f
Compare


Stacked on #398.
Monday: Write a utility to generate all the circuits preprocessed roots
What
Adds a
--formatflag to thecircuit-paramsbinary:info(default) — the existing human-readable output: per-component non-padded row count, padded log size, and usage percentage.json— a JSON array with, per verified trace size, only the per-component padded log sizes.Usage
Example
jsonoutput:[ { "trace_log_size": 25, "components": { "eq": 20, "qm31_ops": 23, "m31_to_u32": 20, "triple_xor": 19, "blake_g_gate": 23 } } ]Tests
The CLI test now covers both formats (
run_circuit_params_binary_info,run_circuit_params_binary_json).🤖 Generated with Claude Code
This change is