Skip to content

XamlX upgrade - #6288

Merged
metalgearsloth merged 10 commits into
space-wizards:masterfrom
sowelipililimute:work/jblackquill/demo-xamlx
Jul 24, 2026
Merged

XamlX upgrade#6288
metalgearsloth merged 10 commits into
space-wizards:masterfrom
sowelipililimute:work/jblackquill/demo-xamlx

Conversation

@sowelipililimute

@sowelipililimute sowelipililimute commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

Requires space-wizards/space-station-14#44513

This updates our XamlX to a newer version that lets us more easily support features such as templated controls and data binding without having to try and backport verifiable code fixes to our 5-year-old fork of XamlX.

Breaking Changes

The syntax for multiple style classes has changed from:

<Control.StyleClasses>
  <system:String>Hello</system:String>
  <system:String>World</system:String>
</Control.StyleClasses>

to

<Control StyleClasses="Hello World" />

Closes #2023.

@sowelipililimute
sowelipililimute force-pushed the work/jblackquill/demo-xamlx branch 2 times, most recently from 94f916f to e128d52 Compare January 10, 2026 05:36
@sowelipililimute

Copy link
Copy Markdown
Contributor Author

mostly working but xaml jit is broken on MethodAccessExceptions and i cannot figure out for the life of me what's going on there (needs content changes for how i reorganized the button styles)

@sowelipililimute
sowelipililimute force-pushed the work/jblackquill/demo-xamlx branch 2 times, most recently from b71f8b9 to fd8a120 Compare January 23, 2026 21:12
@sowelipililimute
sowelipililimute marked this pull request as ready for review January 23, 2026 23:14
@sowelipililimute sowelipililimute added the S: Requires Content PR This PR breaks content and requires both to be merged together. label Jan 23, 2026
@Tayrtahn Tayrtahn linked an issue Jan 24, 2026 that may be closed by this pull request
@sowelipililimute
sowelipililimute force-pushed the work/jblackquill/demo-xamlx branch 2 times, most recently from 431bd10 to 203f276 Compare May 5, 2026 21:36
@mirrorcult

Copy link
Copy Markdown
Contributor

this will close #2023 (although i wasnt even aware it was possible to do it with that weird syntax)

Comment thread .gitmodules Outdated

@Fildrance Fildrance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. CLI build was doing perfectly fine, VS choked a bit due to multiple targets, but was fine after some package restore. Test fail is obviously due to content not being updated with new StyleClass declaration way. We probably merge this one before conent :) not the other way around.

Comment thread Robust.Xaml/XamlJitCompiler.cs
Comment thread Robust.Client/UserInterface/Controls/MultiselectOptionButton.cs
@metalgearsloth
metalgearsloth merged commit bbfd27d into space-wizards:master Jul 24, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S: Requires Content PR This PR breaks content and requires both to be merged together.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XAML UI does not parse two style classes correctly XAML UI should support multiple style classes

5 participants