[SolidMechanics][FEM] Fix FastTetrahedralCorotationalForceField stiffness matrix assembly#6154
Open
th-skam wants to merge 1 commit into
Open
[SolidMechanics][FEM] Fix FastTetrahedralCorotationalForceField stiffness matrix assembly#6154th-skam wants to merge 1 commit into
th-skam wants to merge 1 commit into
Conversation
…ness matrix assembly
alxbilger
approved these changes
Jun 15, 2026
bakpaul
approved these changes
Jun 18, 2026
Contributor
Author
|
[ci-build][with-all-tests] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of an obscure bug.
In
FastTetrahedralCorotationalForceField, due to a missed transpose, the mechanics change if the edge indexing changes. This is observed in case the solver template triggers thebuildStiffnessMatrixpath. The other paths are ok.This can happen in a scene such as the one below. In one case, the topology uses the edges computed by the mesh loader (unstable), in the other case, it re-computes them (stable). The two components register edge indices differently. This also raises another point: do we want to have components that create element arrays in different ways?
Screen.Recording.2026-06-15.133446.mp4
[ci-build][with-all-tests]