Skip to content

[GUI] Factorize camera related code to use in child class#6141

Merged
hugtalbot merged 2 commits into
sofa-framework:masterfrom
bakpaul:06_26_fix_camera_when_reloading
Jun 5, 2026
Merged

[GUI] Factorize camera related code to use in child class#6141
hugtalbot merged 2 commits into
sofa-framework:masterfrom
bakpaul:06_26_fix_camera_when_reloading

Conversation

@bakpaul

@bakpaul bakpaul commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

This PR factorizes piece of code that check for the presence of a camera in the scene to be used in child class when reloading the scene.

[ci-depends-on https://github.com/sofa-framework/SofaGLFW/pull/281]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Jun 4, 2026
@bakpaul bakpaul marked this pull request as ready for review June 4, 2026 07:04
@sofabot

sofabot commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

@th-skam th-skam added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 4, 2026
@sofabot

sofabot commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #2.

All dependencies are merged/closed. Congrats! 👍

@hugtalbot hugtalbot merged commit d8ab500 into sofa-framework:master Jun 5, 2026
12 of 13 checks passed
@hugtalbot hugtalbot added this to the v26.06 milestone Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants