Skip to content

fix(autopilot): stuck 検知が EPIC Decomposed を誤 Block する (#856) #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takaokouji merged 1 commit into from
Jul 1, 2026
Merged

fix(autopilot): stuck 検知が EPIC Decomposed を誤 Block する (#856) #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tools/autopilot/src/phases.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,15 +330,18 @@ function isActionable(item, opts = {}) {
* 死んだ場合、Status が In Progress + AI Status=xxxing のまま誰も再 dispatch せず固まる
* （phaseForItem は In Progress を Self-Reviewing 以外では再開しないため）。
*
* Self-Reviewing は次 tick で自動 dispatch（review）されるので stuck 対象外。AI Status が
* 空の In Progress（人間が手で In Progress にした等）も対象外。実際に「実行中の run が無いか」
* 「十分な時間が経過したか」は I/O・時間を持つ daemon 側で判定する（ここは形だけ見る）。
* Self-Reviewing は次 tick で自動 dispatch（review）されるので stuck 対象外。EPIC Decomposed は
* decompose が正常終了した EPIC の resting 状態（子の実装待ち）で、run を持たなくて当然なので
* 対象外（#856）。AI Status が空の In Progress（人間が手で In Progress にした等）も対象外。
* 実際に「実行中の run が無いか」「十分な時間が経過したか」は I/O・時間を持つ daemon 側で
* 判定する（ここは形だけ見る）。
* @param {object} item { status, aiStatus }
* @returns {boolean}
*/
const STUCK_EXEMPT_AI_STATUSES = new Set(['Self-Reviewing', 'EPIC Decomposed']);
function isStuckCandidate(item) {
if (!item || item.status !== 'In Progress') return false;
if (!item.aiStatus || item.aiStatus === 'Self-Reviewing') return false;
if (!item.aiStatus || STUCK_EXEMPT_AI_STATUSES.has(item.aiStatus)) return false;
return true;
}

Expand Down
3 changes: 3 additions & 0 deletions tools/autopilot/test/phases.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,9 @@ test('isStuckCandidate: In Progress + 作業中 AI Status のみ true', () => {
assert.equal(isStuckCandidate({ status: 'In Progress', aiStatus: 'Decomposing' }), true);
// Self-Reviewing は次 tick で自動 dispatch されるので対象外
assert.equal(isStuckCandidate({ status: 'In Progress', aiStatus: 'Self-Reviewing' }), false);
// EPIC Decomposed は decompose 完了済み EPIC の resting 状態（子の実装待ち）で
// run が無くて当然 → stuck 対象外（#856）
assert.equal(isStuckCandidate({ status: 'In Progress', aiStatus: 'EPIC Decomposed' }), false);
// AI Status 空の In Progress（人間操作）は対象外
assert.equal(isStuckCandidate({ status: 'In Progress', aiStatus: null }), false);
assert.equal(isStuckCandidate({ status: 'In Progress' }), false);
Expand Down