Fix the USB legacy control/status offset - #179
Closed
ArthurHeymans wants to merge 2 commits into
Closed
Conversation
Allow callers to select native, low-high, or high-low access for xHCI 64-bit MMIO registers. Keep native access as the default for existing users while making split access available for platforms and controllers that cannot accept native 64-bit MMIO operations.
The USB legacy support control/status register is the second dword of the capability. Map it at base + 4 instead of aliasing the legacy support semaphore register.
Author
|
This PR is part of a stack of 5 bookmarks:
Created with jj-stack |
This was referenced Aug 5, 2026
Author
|
Superseded by the stacked PR: ArthurHeymans#2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The USB legacy support control/status register lives in the second dword of the capability. Its accessor currently points at the first dword and aliases the semaphore register.
Move the accessor to
base + 4and add a regression check that updates the second dword only.