Configure the tf buffer timer creator in scan_to_scan_filter_chain - #257
Configure the tf buffer timer creator in scan_to_scan_filter_chain#257Hugal31 wants to merge 1 commit into
Conversation
|
Does this approach work for you? I vaguely remember a problem with new transforms not being added to the buffer if the filter is blocking on waitfortransform, because that blocks the executor callback that would handle adding tf messages to the buffer. |
|
Yes does work, I sometimes have to wait a bit on lookupTransform in my filters because of #258. The TransformListener is spinning its own thread and executor, Edit: indeed if the TransformListener didn't spin a dedicated thread if a filter tries to wait for a new one, that would hang everything. However if the tf buffer is shared between the filter chain and each filter, the tf2_ros::MessageFilter would have removed the need to wait for the transform, but you never know when a filter would want to wait for another frame for some reason. |
|
Thanks @Hugal31 - I'll dig into this and the other issues you brought up. I'm busy this week, but I should be able to get to them mid next week. |
Configure the tf buffer by calling setCreateTimerInterface so the message filter can call waitForTransform.
How should I go about making a backport for jazzy?
Closes #256