fix: migrate active goal and tolerances to thread safe box in JTC - #2484
Open
SouriRishik wants to merge 5 commits into
Open
fix: migrate active goal and tolerances to thread safe box in JTC#2484SouriRishik wants to merge 5 commits into
SouriRishik wants to merge 5 commits into
Conversation
github-actions
Bot
requested review from
arne48,
bijoua29,
bmagyar,
destogl and
homalozoa
July 23, 2026 08:09
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2484 +/- ##
==========================================
+ Coverage 86.83% 86.85% +0.02%
==========================================
Files 148 148
Lines 16273 16278 +5
Branches 1368 1369 +1
==========================================
+ Hits 14131 14139 +8
+ Misses 1635 1631 -4
- Partials 507 508 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @christophfroehlich, could you please review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the JointTrajectoryController (JTC) to the modern RealtimeThreadSafeBox API to replace the deprecated RealtimeBuffer for the active goal handle and tolerances.
The migration from stale PR #1480 has been completed and brought up to date with the following fixes:
try_set()calls where the lambda parameter was passed by value ([](auto goal)). This caused the compiler to copy the smart pointer, resulting in the active goal handle never being cleared from the box and causing subsequent actions/tests to fail or timeout.preempt_active_goal()by merging the new box.set()API with the master branch's preemption abort-result delivery logic (active_goal->runNonRealtime()).CMakeLists.txtto define theros2_control_test_assets::ros2_control_test_assetstarget if it is not exported, ensuring compatibility with older ROS environments (such as Humble).This finishes the stale PR #1480 and resolves the test failures.
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
Verified locally that the pre-commit checks run and pass successfully: