Link JTC validation library instead of header-only - #2478
Open
thedevmystic wants to merge 1 commit into
Open
Conversation
github-actions
Bot
requested review from
Maverobot,
aprotyas,
christophfroehlich,
destogl and
mamueluth
July 15, 2026 13:00
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2478 +/- ##
==========================================
+ Coverage 86.83% 86.86% +0.02%
==========================================
Files 148 148
Lines 16273 16271 -2
Branches 1368 1368
==========================================
+ Hits 14131 14133 +2
+ Misses 1635 1630 -5
- Partials 507 508 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, respected maintainers and reviewers! This is Surya!
So, this PR concerns with loading
validate_jtc_parameters.hppas.cpp. If you may remember I did this similar PR previously but it's changes was reverted. This is important for my another PR which is #2133. Without this specific change we get mult. def. errors.Changes in this PR:
validate_jtc_parameters.hppintovalidate_jtc_parameters.cpp.A question: While I did a traditional
.hpp/.cppapproach we can also just inline it to satisfy ODR. If we want that then I can rewrite it as inline.