Use new Command/State Interfaces API for tests - #2476
Open
saikishor wants to merge 28 commits into
Open
Conversation
saikishor
marked this pull request as draft
July 14, 2026 21:43
saikishor
marked this pull request as ready for review
July 15, 2026 17:09
github-actions
Bot
requested review from
Maverobot,
destogl,
erickisos and
fmauch
July 15, 2026 17:09
christophfroehlich
left a comment
Member
There was a problem hiding this comment.
Overall LGTM and mostly straight forward. Some comments, then good to be merged.
| traction_joints_names_[0], traction_interface_name_, | ||
| &joint_command_values_[CMD_TRACTION_RIGHT_WHEEL])); | ||
| traction_joints_names_[0], traction_interface_name_)); | ||
| std::ignore = command_itfs_.back()->set_value(joint_command_values_[CMD_TRACTION_RIGHT_WHEEL]); |
Member
There was a problem hiding this comment.
joint_command_values_ et.al can be constants now. Maybe we can cleanup the member variables of the test fixtures in a follow-up PR.
| std::vector<hardware_interface::StateInterface::SharedPtr> on_export_state_interfaces_list() | ||
| override; | ||
|
|
||
| std::vector<hardware_interface::CommandInterface::SharedPtr> on_export_reference_interfaces_list() |
Member
There was a problem hiding this comment.
will this be a mandatory override? or why this change, this is exactly the default implementation in chainable_controller_interface.cpp
| std::vector<hardware_interface::StateInterface::SharedPtr> on_export_state_interfaces_list() | ||
| override; | ||
|
|
||
| std::vector<hardware_interface::CommandInterface::SharedPtr> on_export_reference_interfaces_list() |
| std::vector<hardware_interface::StateInterface::SharedPtr> on_export_state_interfaces_list() | ||
| override; | ||
|
|
||
| std::vector<hardware_interface::CommandInterface::SharedPtr> on_export_reference_interfaces_list() |
| joint_state_vel_[i] = INITIAL_VEL_JOINTS[i]; | ||
| joint_state_acc_[i] = INITIAL_ACC_JOINTS[i]; | ||
| } | ||
| (void)pos_state_interfaces_.back()->set_value( |
Member
There was a problem hiding this comment.
should we use std::ignore to have consistent style in this repo?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to migrate from the old API of the handles to the new one where is no more reference of the variables
Is this user-facing behavior change?
NO
Did you use Generative AI?
YES, for failing tests
Additional Information
TODOs
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)