Use new chainable controller exports API (backport #2350) - #2454
Open
mergify[bot] wants to merge 2 commits into
Open
Use new chainable controller exports API (backport #2350)#2454mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
(cherry picked from commit 8ad7d35) # Conflicts: # diff_drive_controller/test/test_diff_drive_controller.cpp # mecanum_drive_controller/test/test_mecanum_drive_controller.cpp # omni_wheel_drive_controller/test/test_omni_wheel_drive_controller.cpp # steering_controllers_library/src/steering_controllers_library.cpp # steering_controllers_library/test/test_steering_controllers_library.cpp
Contributor
Author
|
Cherry-pick of 8ad7d35 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
Author
|
Tick the box to add this pull request to the merge queue (same as
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## kilted #2454 +/- ##
==========================================
+ Coverage 86.92% 86.98% +0.05%
==========================================
Files 156 156
Lines 15583 15692 +109
Branches 1340 1341 +1
==========================================
+ Hits 13545 13649 +104
- Misses 1569 1572 +3
- Partials 469 471 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
left a comment
Member
There was a problem hiding this comment.
@saikishor the ABI breaks are fine for us, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've migrated the controllers to the new chainable controller export API, the older API needs to be deprecated soon.
Related to ros-controls/ros2_control#2988
This is an automatic backport of pull request #2350 done by Mergify.