Skip to content

Add reference limiter to steering_controllers library - #2413

Open
christophfroehlich wants to merge 6 commits into
masterfrom
steering-add-limiter
Open

Add reference limiter to steering_controllers library#2413
christophfroehlich wants to merge 6 commits into
masterfrom
steering-add-limiter

Conversation

@christophfroehlich

Copy link
Copy Markdown
Member

Description

Add reference limiter to steering_controllers library, similar to #2313

Fixes #2129

Is this user-facing behavior change?

Only if parameterized as such.

Did you use Generative AI?

GPT-5.3 Codex to apply the changes from #2313 to the steering lib.

@christophfroehlich
christophfroehlich marked this pull request as ready for review June 13, 2026 20:57
@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.11688% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.85%. Comparing base (8ad7d35) to head (1ad407c).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...llers_library/src/steering_controllers_library.cpp 59.01% 22 Missing and 3 partials ⚠️
...library/test/test_steering_controllers_library.cpp 98.92% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2413      +/-   ##
==========================================
- Coverage   86.88%   86.85%   -0.03%     
==========================================
  Files         148      148              
  Lines       16207    16354     +147     
  Branches     1362     1372      +10     
==========================================
+ Hits        14081    14204     +123     
- Misses       1618     1640      +22     
- Partials      508      510       +2     
Flag Coverage Δ
unittests 86.85% <83.11%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...library/test/test_steering_controllers_library.hpp 97.64% <ø> (ø)
...library/test/test_steering_controllers_library.cpp 98.92% <98.92%> (ø)
...llers_library/src/steering_controllers_library.cpp 65.42% <59.01%> (-1.76%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Jun 13, 2026
@christophfroehlich christophfroehlich moved this to Needs review in Review triage Jun 13, 2026
@mergify

mergify Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

This pull request is in conflict. Could you fix it @christophfroehlich?

Adopt new chainable controller exports API (#2350) in the steering
speed-limiter code: use on_export_reference_interfaces_list() and
ordered_exported_reference_interfaces_ instead of reference_interfaces_.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

[steering_controllers_library] Implement velocity limits (Consistency with DiffDrive)

1 participant