Add filtering capability to ft_broadcaster (backport #1814) - #1927
Merged
Conversation
Co-authored-by: Denis Štogl <denis@stogl.de> Co-authored-by: Guillaume Walck <guihome@wanadoo.fr> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Co-authored-by: Xavier Guay <xavguay@gmail.com> Co-authored-by: Aarav Gupta <amronos275@gmail.com> Co-authored-by: Oscar Lima <olima_84@yahoo.com> Co-authored-by: Hilary Luo <103377417+hilary-luo@users.noreply.github.com> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com> (cherry picked from commit 4f9c462) # Conflicts: # doc/release_notes.rst # force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster.cpp
Contributor
Author
|
Cherry-pick of 4f9c462 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## jazzy #1927 +/- ##
==========================================
+ Coverage 85.52% 85.57% +0.04%
==========================================
Files 137 138 +1
Lines 13171 13231 +60
Branches 1143 1146 +3
==========================================
+ Hits 11265 11322 +57
- Misses 1544 1547 +3
Partials 362 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good morning!
This is a continuation of #559 as it was inactive.
The changes are minimal:
sensor_filter_chainto the parameters, which serves as documentation.IMHO, the previous tests were testing the business logic of the filters themselves, that is, checking that the actual computations were correct, rather than the actual new logic for adding filters. I added three tests for configuring, activating/deactivating, and updating with a configured filter chain. Just one consideration: I changed a little bit the logic of SetUpFTSBroadcaster a little bit to accept a node name. This is because I added some parameters in the YAML that are needed for the broadcaster with filters. I cannot do
set_parameterbecause the filter chain expects the parameters to be overrides.Thanks a lot for your time!
Óscar
This is an automatic backport of pull request #1814 done by Mergify.