Skip to content

EPMRPP-117731 || 'Caps Lock' icon is displayed in the password fields even when the Caps Lock is off reopened 2#314

Merged
VaheSamsonyan merged 2 commits into
developfrom
bugfix/EPMRPP-117731-Caps-Lock-icon-is-displayed-in-the-password-fields-even-when-the-Caps-Lock-is-off-reopened-2
Jul 16, 2026
Merged

EPMRPP-117731 || 'Caps Lock' icon is displayed in the password fields even when the Caps Lock is off reopened 2#314
VaheSamsonyan merged 2 commits into
developfrom
bugfix/EPMRPP-117731-Caps-Lock-icon-is-displayed-in-the-password-fields-even-when-the-Caps-Lock-is-off-reopened-2

Conversation

@VaheSamsonyan

@VaheSamsonyan VaheSamsonyan commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

fixing the caps lock logic while focusing and unfocusing

Visuals

BEFORE:

beforefix.mp4

AFTER:

afterfix.mp4

Summary by CodeRabbit

  • Bug Fixes
    • Improved Caps Lock detection for text fields.
    • Caps Lock status now synchronizes correctly when users interact with fields using the mouse.
    • Existing behavior for displaying Caps Lock warnings remains intact.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@VaheSamsonyan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 39d6e640-ec01-4286-bc07-7826925cdc34

📥 Commits

Reviewing files that changed from the base of the PR and between 72c96f2 and 9c78b5a.

📒 Files selected for processing (1)
  • src/components/fieldText/fieldText.tsx

Walkthrough

useCapsLock now synchronizes Caps Lock from keyboard and mouse events, while preserving visibility-reset behavior. FieldText invokes the new synchronization callback on input mouse-down when Caps Lock messaging is enabled.

Changes

Caps Lock synchronization

Layer / File(s) Summary
Hook state tracking
src/common/hooks/useCapsLock.ts
Adds syncFromMouseEvent, dedicated key handlers, updated listener cleanup, and the expanded hook return value.
FieldText mouse synchronization
src/components/fieldText/fieldText.tsx
Passes native mouse-down events to the hook when capsLockMessage is provided.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: siarheirazuvalau, allaprischepa

Poem

I’m a bunny with keys, hopping bright,
Caps Lock now follows mouse clicks just right.
Downstroke and upstroke, the state stays in tune,
Visibility resets beneath the moon.
Nibble nibble—the hook’s flow is new!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references the Caps Lock icon issue in password fields, which matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/EPMRPP-117731-Caps-Lock-icon-is-displayed-in-the-password-fields-even-when-the-Caps-Lock-is-off-reopened-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/fieldText/fieldText.tsx`:
- Around line 180-182: Update the FieldText props destructuring to extract
onMouseDown from rest, then modify the input’s onMouseDown handler to run Caps
Lock synchronization and invoke the consumer-provided handler when present. Keep
the existing rest spread without onMouseDown so it cannot overwrite the internal
handler.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9ae0fb12-6a73-4740-9c74-d1725c008277

📥 Commits

Reviewing files that changed from the base of the PR and between 6522cbc and 72c96f2.

📒 Files selected for processing (2)
  • src/common/hooks/useCapsLock.ts
  • src/components/fieldText/fieldText.tsx

Comment thread src/components/fieldText/fieldText.tsx
@VaheSamsonyan
VaheSamsonyan merged commit f014a5f into develop Jul 16, 2026
2 checks passed
@VaheSamsonyan
VaheSamsonyan deleted the bugfix/EPMRPP-117731-Caps-Lock-icon-is-displayed-in-the-password-fields-even-when-the-Caps-Lock-is-off-reopened-2 branch July 16, 2026 10:07
github-actions Bot pushed a commit that referenced this pull request Jul 16, 2026
… even when the Caps Lock is off reopened 2 (#314)

* covering unfocus then changing the OS caps log state

* fix

---------

Co-authored-by: vahesamsonyan <vahe_samsonyan@epam.com> f014a5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants