Skip to content

EPMRPP-117802 || Caps Lock icon is clickable and hidden when clicking on it#315

Merged
VaheSamsonyan merged 1 commit into
developfrom
bugfix/EPMRPP-117802-Caps-Lock-icon-is-clickable-and-hidden-when-clicking-on-it
Jul 17, 2026
Merged

EPMRPP-117802 || Caps Lock icon is clickable and hidden when clicking on it#315
VaheSamsonyan merged 1 commit into
developfrom
bugfix/EPMRPP-117802-Caps-Lock-icon-is-clickable-and-hidden-when-clicking-on-it

Conversation

@VaheSamsonyan

@VaheSamsonyan VaheSamsonyan commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

icon is not clickable anymore + optional chaining added

Summary by CodeRabbit

  • Bug Fixes

    • Improved Caps Lock detection across keyboard, mouse, autofill, and password-manager interactions.
    • Prevented errors when Caps Lock state information is unavailable.
    • Ensured field focus and blur behavior remains consistent.
    • Prevented unintended focus changes when interacting with the Caps Lock indicator.
  • Style

    • Updated the Caps Lock tooltip cursor to use the default pointer appearance.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b38d445d-87a8-47aa-8cd5-9d142e9f4ae9

📥 Commits

Reviewing files that changed from the base of the PR and between 1a48987 and 7ad0545.

📒 Files selected for processing (3)
  • src/common/hooks/useCapsLock.ts
  • src/components/fieldText/fieldText.module.scss
  • src/components/fieldText/fieldText.tsx

Walkthrough

Caps Lock detection now safely supports events with optional native modifier accessors. FieldText updates event-handler precedence, mouse synchronization, and tooltip pointer behavior.

Changes

Caps Lock handling

Layer / File(s) Summary
Caps Lock state contract and synchronization
src/common/hooks/useCapsLock.ts
Adds a broader event shape and shared fallback-safe modifier-state helper for mouse and keyboard events.
FieldText event and tooltip integration
src/components/fieldText/fieldText.tsx, src/components/fieldText/fieldText.module.scss
Ensures internal input handlers take precedence, synchronizes from compatible mouse events, prevents icon mousedown defaults, removes tooltip wrapper tab focus, and sets the default cursor.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: siarheirazuvalau, allaprischepa

Poem

I’m a rabbit guarding the key,
Caps Lock now handles events safely.
Mouse hops in, keys join the queue,
The tooltip keeps its focus true.
Thump-thump! Clean handlers bloom anew.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title refers to the Caps Lock icon click behavior, which matches the main UI change in this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/EPMRPP-117802-Caps-Lock-icon-is-clickable-and-hidden-when-clicking-on-it

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: dependency version conflict. Check your lock file or package.json.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@VaheSamsonyan
VaheSamsonyan merged commit 0d17ead into develop Jul 17, 2026
2 checks passed
@VaheSamsonyan
VaheSamsonyan deleted the bugfix/EPMRPP-117802-Caps-Lock-icon-is-clickable-and-hidden-when-clicking-on-it branch July 17, 2026 08:59
github-actions Bot pushed a commit that referenced this pull request Jul 17, 2026
Co-authored-by: vahesamsonyan <vahe_samsonyan@epam.com> 0d17ead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants