chore(deps): bump electron from 35.7.5 to 39.8.5#1094
Open
JamieRuderman wants to merge 2 commits into
Open
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
electronfrom 35.7.5 to 39.8.5 (4-major: 35 → 36 → 37 → 38 → 39).plugin-crashedwebContentslistener in ElectronApp.ts:323 — the event was removed in Electron 38 when Chromium dropped plugin support, so it never fires anyway. The neighboringrender-process-gonelistener still covers crash logging.What's new across 35 → 39 (high-level)
ipcMainhandlers no longer receive sender frame;WebFrameMain.urlsemantics tightened.runningUnderRosettaTranslation,session.preconnect.keepSocket).plugin-crashedevent removed (this PR).A repo-wide grep for the commonly-removed APIs (
runningUnderRosettaTranslation,shell.beep,continueAtSelection,session.preconnect) returned no matches.Local verification
npm installsucceeds, including /electron postinstall (electron-builderinstall-app-depsrebuilt native deps against 39.8.5, binary-installer downloaded all bins)cd electron && npm run compile— typecheck passes (was the CircleCI failure point on chore(deps-dev): bump electron from 35.7.5 to 39.8.5 #1071)cd electron && npm test— 20/20 jest tests passTest plan
npm startin/electronlocally: dev shell launches, window renders, no console regressions