AI Generated: Refactor gentest#1889
Closed
NickGerleman wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94005983. |
Contributor
Author
|
FYI @intergalacticspacehighway. Was having reliability issues with the script, and saw the hacks related to the Changes are in last commit in the PR: 52c813d |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Feb 22, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count (3500 lines before and after) Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
52c813d to
931ba1e
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Feb 22, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count (3500 lines before and after) Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
931ba1e to
0236643
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Feb 22, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count (3500 lines before and after) Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
0236643 to
8f96ca1
Compare
cortinico
requested changes
Mar 3, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Mar 7, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style in DOM, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
8f96ca1 to
d679061
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Mar 7, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style in DOM, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
d679061 to
70d7c07
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Mar 7, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style in DOM, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
70d7c07 to
ba5100d
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style in DOM, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count Reviewed By: sammy-SC Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
ba5100d to
f10802f
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style in DOM, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count Reviewed By: sammy-SC Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
f10802f to
9805442
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style in DOM, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count Reviewed By: sammy-SC Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
9805442 to
09e65c7
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style in DOM, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count Reviewed By: sammy-SC Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
09e65c7 to
572b406
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style in DOM, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count Reviewed By: sammy-SC Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
572b406 to
fa26de3
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style in DOM, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count Reviewed By: sammy-SC Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
fa26de3 to
0c8fd87
Compare
Summary: Pull Request resolved: react#1889 This change used Claude to make some major quality of life changes to `yarn gentest`. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style in DOM, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel. We avoid outputting temp files to source root. From there, I looked over major parts, and had it clean up a lot of things to taste, but I let it try to do a full rewrite for simplicity, using the original as reference. It is about neutral in terms of line count Reviewed By: sammy-SC Differential Revision: D94005983
NickGerleman
force-pushed
the
export-D94005983
branch
from
0c8fd87 to
1f2d2c8
Compare
|
This pull request has been merged in dcaa7ca. |
J8118
added a commit
to J8118/yoga
that referenced
this pull request
Apr 9, 2026
The file is recorded in git as types.ts (lowercase) but all 7 imports referenced Types.ts (uppercase). This casing mismatch was introduced in dcaa7ca (react#1889) and causes TS1261 on case-insensitive filesystems.
meta-codesync Bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
Summary: The file `gentest/src/types.ts` is recorded in git with a lowercase `t`, but all 7 imports across the gentest source reference `Types.ts` (uppercase `T`). This casing mismatch was introduced in #1889 (`dcaa7ca7`) when the gentest was rewritten — the file was created as `types.ts` but the imports were written as `Types.ts` in the same commit. This causes TypeScript error TS1261 on case-insensitive filesystems (Windows/macOS) where the filesystem resolves both casings to the same file but TypeScript flags the inconsistency. On case-sensitive filesystems (Linux), the mismatched casing could cause module resolution issues depending on the TypeScript configuration. **Files changed (7 import corrections):** - `gentest/src/cli.ts` - `gentest/src/CssToYoga.ts` - `gentest/src/buildLayoutTree.ts` - `gentest/src/emitters/Emitter.ts` - `gentest/src/emitters/CppEmitter.ts` - `gentest/src/emitters/JavascriptEmitter.ts` - `gentest/src/emitters/JavaEmitter.ts` Pull Request resolved: #1929 Test Plan: - `yarn workspace gentest run tsc` now passes cleanly (previously failed with TS1261) - Import-only change — no logic modifications Reviewed By: NickGerleman Differential Revision: D100144393 Pulled By: fabriziocucci fbshipit-source-id: 273124bb478a6c6441b60ac8b086236440e0a90a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change used Claude to make some major quality of life changes to
yarn gentest. The bulk of the logic is now run in the driver, instead of the browser, and the scripts are typechecked. We rely on attributes, instead of declared style, so that we don't miss inputs the browser massages. We no longer preprocess the fixtures, to remap invalid CSS properties to valid ones. Generation now happens in parallel.It is about neutral in terms of line count (3500 lines before and after)
Differential Revision: D94005983