Fix import casing mismatch for gentest types.ts#1929
Closed
J8118 wants to merge 3 commits into
Closed
Conversation
The file is recorded in git as types.ts (lowercase) but all 7 imports referenced Types.ts (uppercase). This casing mismatch was introduced in dcaa7ca (react#1889) and causes TS1261 on case-insensitive filesystems.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
facebook-github-tools
Bot
added
the
Shared with Meta
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D100144393. |
|
@fabriziocucci merged this pull request in 0ea34b7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file
gentest/src/types.tsis recorded in git with a lowercaset, but all 7 imports across the gentest source referenceTypes.ts(uppercaseT). This casing mismatch was introduced in #1889 (dcaa7ca7) when the gentest was rewritten — the file was created astypes.tsbut the imports were written asTypes.tsin the same commit.This causes TypeScript error TS1261 on case-insensitive filesystems (Windows/macOS) where the filesystem resolves both casings to the same file but TypeScript flags the inconsistency. On case-sensitive filesystems (Linux), the mismatched casing could cause module resolution issues depending on the TypeScript configuration.
Files changed (7 import corrections):
gentest/src/cli.tsgentest/src/CssToYoga.tsgentest/src/buildLayoutTree.tsgentest/src/emitters/Emitter.tsgentest/src/emitters/CppEmitter.tsgentest/src/emitters/JavascriptEmitter.tsgentest/src/emitters/JavaEmitter.tsTest plan
yarn workspace gentest run tscnow passes cleanly (previously failed with TS1261)