Skip to content

use 'trigger-workflow-and-wait' from 'rapidsai/shared-actions'#119

Merged
rapids-bot[bot] merged 3 commits into
mainfrom
shared-actions
Jun 3, 2026
Merged

use 'trigger-workflow-and-wait' from 'rapidsai/shared-actions'#119
rapids-bot[bot] merged 3 commits into
mainfrom
shared-actions

Conversation

@jameslamb
Copy link
Copy Markdown
Member

@jameslamb jameslamb commented Jun 2, 2026

Contributes to #118

Switches from our fork of trigger-workflow-and-wait (https://github.com/rapidsai/trigger-workflow-and-wait) to a vendored copy in rapidsai/shared-actions (added in rapidsai/shared-actions#114).

See the issue for details on the benefits of that.

Notes for Reviewers

How I tested this

On this branch, pinned all these uses to the branch from rapidsai/shared-actions#114 (vendor-trigger-workflow-and-wait).

Started a run from this PR's branch (shared-actions): https://github.com/rapidsai/workflows/actions/runs/26843781233/job/79157749196

Saw everything trigger successfully and the waiting behavior appear to work:

image

Saw statuses handled correctly (e.g. successful dask-cuda-build triggering a dask-cuda-tests job).

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 2, 2026
Comment thread .github/workflows/nightly-pipeline.yaml Outdated
@jameslamb jameslamb changed the title WIP: use 'trigger-workflow-and-wait' from 'rapidsai/shared-actions' use 'trigger-workflow-and-wait' from 'rapidsai/shared-actions' Jun 2, 2026
@jameslamb jameslamb marked this pull request as ready for review June 2, 2026 20:31
@jameslamb jameslamb requested a review from a team as a code owner June 2, 2026 20:31
@jameslamb jameslamb requested a review from KyleFromNVIDIA June 2, 2026 20:31
rapids-bot Bot pushed a commit to rapidsai/shared-actions that referenced this pull request Jun 2, 2026
Contributes to rapidsai/workflows#118

Vendors https://github.com/rapidsai/trigger-workflow-and-wait in here, so that repo can be archived. See the issue for details on the benefits of that.

## Notes for Reviewers

### I've intentionally structured the commits

In order:

1. 0b05d5d = vendor without modification
2. 653df59 = NVIDIA copyrights, licensing, ownership
3. 2424524 = RAPIDS-ifying (removing unnecessary-to-us stuff, updating examples to point to RAPIDS things)

This PR can be squash merged, but just structured the commits that way for ease of reviewing.

### How I tested this

Ran the testing instructions in the README locally, saw them successfully trigger a `build.yaml` run in RMM.

Tried manually triggering a nightly pipeline with this in rapidsai/workflows#119, saw it all appear to work well.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #114
@jameslamb jameslamb removed the request for review from KyleFromNVIDIA June 3, 2026 01:16
@jameslamb
Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot Bot merged commit 973e498 into main Jun 3, 2026
2 checks passed
@jameslamb jameslamb deleted the shared-actions branch June 3, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants