vendor trigger workflow and wait by jameslamb · Pull Request #114 · rapidsai/shared-actions

jameslamb · 2026-06-02T19:38:26Z

Vendors https://github.com/rapidsai/trigger-workflow-and-wait in here, so that repo can be archived. See the issue for details on the benefits of that.

Notes for Reviewers

I've intentionally structured the commits

In order:

0b05d5d = vendor without modification
653df59 = NVIDIA copyrights, licensing, ownership
2424524 = RAPIDS-ifying (removing unnecessary-to-us stuff, updating examples to point to RAPIDS things)

This PR can be squash merged, but just structured the commits that way for ease of reviewing.

How I tested this

Ran the testing instructions in the README locally, saw them successfully trigger a build.yaml run in RMM.

Tried manually triggering a nightly pipeline with this in rapidsai/workflows#119, saw it all appear to work well.

bdice · 2026-06-02T20:01:52Z

+    required: false
+    default: ''
+  comment_github_token:
+    description: "The Github access token with access to the repository for comment URL. It is recommended you put this token under secrets."


This Github -> GitHub (or github -> GitHub) applies in a few places.

Suggested change

description: "The Github access token with access to the repository for comment URL. It is recommended you put this token under secrets."

description: "The GitHub access token with access to the repository for comment URL. It is recommended you put this token under secrets."

Fixed this everywhere I could find it: f8526ec

bdice · 2026-06-02T20:03:33Z

+    echo "Error: Github token is required. You can head over settings and"
+    echo "under developer, you can create a personal access tokens. The"


Let's polish the grammar up a bit... I know it's vendored code but the prose is not written very well. Just have an agent do a single pass over the whole PR to improve grammar.

Ran through this and the README in f8526ec and made some changes.

bdice · 2026-06-02T20:04:52Z

Are we running shellcheck? Can we please do that?

We aren't yet, sure I'll add that here.

Added in f8526ec

That pulled in some changes in telemetry-related actions too, but they look non-controversial to me so I think they're fine to keep.

bdice · 2026-06-02T20:05:14Z

+| `trigger_workflow`       | False      | `true`      | Trigger the specified workflow. |
+| `wait_workflow`          | False      | `true`      | Wait for workflow to finish. |
+| `comment_downstream_url` | False      | ``          | A comments API URL to comment the current downstream job URL to. Default: no comment |
+| `comment_github_token`   | False      | `${{github.token}}`          | token used for pull_request comments |


Let's reflow this table.

Wasn't really sure what you were looking for here.

Since we're now modifying the vendored code, I took the liberty of removing anything related to posting a comment somewhere (we don't use this action for that in RAPIDS).

Otherwise, made the table match the descriptions in the action.yaml here: b1d1406

Let me know what else you're looking for (or push changes yourself if you want).

bdice · 2026-06-02T20:06:00Z

+## History
+
+> [!NOTE]
+> This action contains RAPIDs-specific commits on top of the archived project `convictional/trigger-workflow-and-wait` [link](https://github.com/convictional/trigger-workflow-and-wait).


Typo. Also should we say "NVIDIA" instead of "RAPIDS"?

Suggested change

> This action contains RAPIDs-specific commits on top of the archived project `convictional/trigger-workflow-and-wait` [link](https://github.com/convictional/trigger-workflow-and-wait).

> This action contains RAPIDS-specific commits on top of the archived project `convictional/trigger-workflow-and-wait` [link](https://github.com/convictional/trigger-workflow-and-wait).

Yes typo and yes NVIDIA would be fine.

changed to NVIDIA in f8526ec

jameslamb · 2026-06-02T23:49:48Z

/merge

Contributes to #118 Switches from our fork of `trigger-workflow-and-wait` (https://github.com/rapidsai/trigger-workflow-and-wait) to a vendored copy in `rapidsai/shared-actions` (added in rapidsai/shared-actions#114). See the issue for details on the benefits of that. ## Notes for Reviewers ### How I tested this On this branch, pinned all these uses to the branch from rapidsai/shared-actions#114 (`vendor-trigger-workflow-and-wait`). Started a run from this PR's branch (`shared-actions`): https://github.com/rapidsai/workflows/actions/runs/26843781233/job/79157749196 Saw everything trigger successfully and the waiting behavior appear to work: <img width="1840" height="628" alt="image" src="https://github.com/user-attachments/assets/d856545e-6103-44d7-992c-30a994aaaf13" /> Saw statuses handled correctly (e.g. successful `dask-cuda-build` triggering a `dask-cuda-tests` job). Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #119

jameslamb added 3 commits June 2, 2026 13:55

vendor rapidsai/trigger-workflow-and-wait

0b05d5d

add history callout and NVIDIA copyrights

653df59

RAPIDS-ify

2424524

jameslamb added the improvement Improves an existing functionality label Jun 2, 2026

This was referenced Jun 2, 2026

use 'trigger-workflow-and-wait' from 'rapidsai/shared-actions' rapidsai/workflows#119

Merged

proposal: move trigger-workflow-and-wait to rapidsai/shared-actions rapidsai/workflows#118

Closed

jameslamb changed the title ~~WIP: vendor trigger workflow and wait~~ vendor trigger workflow and wait Jun 2, 2026

jameslamb marked this pull request as ready for review June 2, 2026 19:57

jameslamb requested a review from a team as a code owner June 2, 2026 19:57

jameslamb requested a review from gforsyth June 2, 2026 19:57

bdice reviewed Jun 2, 2026

View reviewed changes

jameslamb added 2 commits June 2, 2026 15:39

add shellcheck, pass for grammar, remove comment-posting functionality

f8526ec

update table

b1d1406

jameslamb requested a review from bdice June 2, 2026 20:56

bdice approved these changes Jun 2, 2026

View reviewed changes

rapids-bot Bot merged commit 6fb2529 into main Jun 2, 2026
3 checks passed

jameslamb deleted the vendor-trigger-workflow-and-wait branch June 2, 2026 23:49

	description: "The Github access token with access to the repository for comment URL. It is recommended you put this token under secrets."
	description: "The GitHub access token with access to the repository for comment URL. It is recommended you put this token under secrets."

		echo "Error: Github token is required. You can head over settings and"
		echo "under developer, you can create a personal access tokens. The"

	> This action contains RAPIDs-specific commits on top of the archived project `convictional/trigger-workflow-and-wait` [link](https://github.com/convictional/trigger-workflow-and-wait).
	> This action contains RAPIDS-specific commits on top of the archived project `convictional/trigger-workflow-and-wait` [link](https://github.com/convictional/trigger-workflow-and-wait).

Conversation

jameslamb commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes for Reviewers

I've intentionally structured the commits

How I tested this

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jameslamb commented Jun 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jameslamb commented Jun 2, 2026 •

edited

Loading