chore(react-native-babel-preset): drop pr56816, superseded upstream#49
Merged
Conversation
ramonclaudio
force-pushed
the
chore/drop-babel-preset-pr56816
branch
from
cb94ee2 to
dbebb41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
@react-native/babel-preset#56816 patches. The PR was closed upstream on 06-04: the React Native team preferred cherry-picking the three Hermes V1 codegen fixes directly onto the250829098.0.0-stablebranch RN 0.85 ships, rather than working around them in Babel.@react-native/babel-presetrow from the Open tablebun,npm, andpnpmpatches underpackages/@react-native/babel-preset/The replacements land here as
hermessource patches: facebook/hermes#2045 (object-literal accessor home object) and facebook/hermes#2046 (class-in-finally var caching), alongside the pre-existing facebook/hermes#2030 (async-arrow non-simple params). Root cause facebook/hermes#1761.