feat(hermes): add pr2045 object-literal accessor home-object patch#55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
hermessource patch for facebook/hermes#2045, a cherry-pick of18a9634659onto the250829098.0.0-stablebranch React Native 0.85 ships.genObjectExprpassednullptras the home object when generating an object-literal getter or setter, sosuper.xinside an accessor compiled against a null home object and SIGSEGV'dhermescat compile time. The cherry-pick makes accessors passcapturedObj, matching the regular-method path.Source-level replacement for the
super-in-object-accessor workaround dropped with@react-native/babel-preset#56816. Apply withgit applyagainst afacebook/hermesV1 checkout. Root cause facebook/hermes#1761.packages/hermes/hermes-pr2045.patchhermesrow to the Open table(supersedes #50, which GitHub auto-closed when its stacked base branch was deleted on merge of #49)