Skip to content

Fix InStereo2k disparity scale #9639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marchematics wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

Fix InStereo2k disparity scale #9639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/test_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3297,6 +3297,16 @@ def test_splits(self):
for left, right, disparity in dataset:
datasets_utils.shape_test_for_stereo(left, right, disparity)

def test_disparity_scale(self):
with self.create_dataset(split="train") as (dataset, _):
disparity_path = dataset._disparities[0][0]
disparity_image = PIL.Image.fromarray(
np.full((100, 200), 100, dtype=np.uint16)
)
disparity_image.save(disparity_path)
disparity = dataset._read_disparity(disparity_path)[0]
np.testing.assert_array_equal(disparity, np.ones((1, 100, 200)))

def test_bad_input(self):
with pytest.raises(
ValueError, match="Unknown value 'bad' for argument split. Valid values are {'train', 'test'}."
Expand Down
2 changes: 1 addition & 1 deletion torchvision/datasets/_stereo_matching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@ def __init__(self, root: Union[str, Path], split: str = "train", transforms: Opt
def _read_disparity(self, file_path: str) -> tuple[np.ndarray, None]:
disparity_map = np.asarray(Image.open(file_path), dtype=np.float32)
# unsqueeze disparity to (C, H, W)
disparity_map = disparity_map[None, :, :] / 1024.0
disparity_map = disparity_map[None, :, :] / 100.0
valid_mask = None
return disparity_map, valid_mask

Expand Down