Fix InStereo2k disparity scale - #9639
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9639
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @Marchematics! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
There was a problem hiding this comment.
Pull request overview
Fixes the scaling applied when decoding InStereo2k disparity PNGs so the returned disparity values are in the correct units.
Changes:
- Update InStereo2k disparity decoding scale factor from
/ 1024.0to/ 100.0. - Add a regression test that writes a known 16-bit disparity PNG value and verifies the decoded disparity equals
1.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| torchvision/datasets/_stereo_matching.py | Correct InStereo2k disparity normalization factor during PNG decoding. |
| test/test_datasets.py | Add regression test validating InStereo2k disparity scaling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Fix InStereo2k disparity scale.