Skip to content

fix(factory): render an unavailable change-failure rate instead of 0.0 percent #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
castrojo wants to merge 1 commit into
base: v4
Choose a base branch
from
+18 −2
Open

fix(factory): render an unavailable change-failure rate instead of 0.0 percent #1120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions scripts/metrics-panels.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,21 @@ function render(fixtures) {

// ── Tests ──────────────────────────────────────────────────────────────────

test("null change failure rate renders unavailable marker, never 0.0%", () => {
const doraNullRate = {
...DORA,
current: { ...DORA.current, changeFailureRate: null },
};
const html = render({
countme: COUNTME_FULL,
brew: BREW,
dora: doraNullRate,
scorecard: SCORECARD,
});
assert.ok(!html.includes("0.0%"));
assert.ok(html.includes("—"));
});

test("lead time renders as not-measured, never as 0", () => {
const html = render({
countme: COUNTME_FULL,
Expand Down
5 changes: 3 additions & 2 deletions src/components/factory/panels/MetricsPanels.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ interface DoraMonthly {
}
interface DoraCurrent {
deploymentsPerWeek: number;
changeFailureRate: number;
changeFailureRate: number | null;
medianLeadTimeHours: number | null;
leadTimeReason?: string;
}
Expand Down Expand Up @@ -113,7 +113,8 @@ function fmt(n: number | null | undefined): string {
return n.toLocaleString("en-US");
}

function pct(n: number): string {
function pct(n: number | null | undefined): string {
if (n == null || !Number.isFinite(n)) return "—";
return `${(n * 100).toFixed(1)}%`;
}

Expand Down