fix(factory): render an unavailable change-failure rate instead of 0.0 percent - #1120
Open
castrojo wants to merge 1 commit into
Open
fix(factory): render an unavailable change-failure rate instead of 0.0 percent#1120castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
pct() multiplied null by 100, so a missing changeFailureRate from fetch-dora.js (deliberately null when no terminal runs exist) rendered as a misleading 0.0%. pct() now treats null/undefined/non-finite inputs as unavailable and renders "—", reserving 0.0% for real measured values. Fixes projectbluefin#1091 Signed-off-by: castrojo <castrojo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pct(n)inMetricsPanels.tsxmultipliednullby 100, so whenfetch-dora.jsdeliberately emitsnullforchangeFailureRate(no terminal runs exist), the UI rendered a misleading0.0%.Fix
pct()now treatsnull/undefined/non-finite inputs as unavailable and renders—, reserving0.0%for real measured values. Updated theDoraCurrent.changeFailureRatetype tonumber | nullto reflect whatfetch-dora.jsactually produces.Testing
scripts/metrics-panels.test.jsasserting anullchangeFailureRaterenders—and never0.0%.node --test scripts/metrics-panels.test.js— all 12 tests pass.Fixes #1091
— hive: backend=copilot model=claude-sonnet-5
🐝 Hive Agent:
contributor| SHA:b8bb3b48