Skip to content

Clarify saved job draft during authentication #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
profilesearch merged 2 commits into from
Jul 21, 2026
Merged

Clarify saved job draft during authentication #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
248280c
Clarify saved draft during authentication
profilesearch Jul 21, 2026
b73aca6
Cover bare post-job auth redirects
profilesearch Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2368,13 +2368,18 @@ <h1 class="detail-title">${esc(job.title)}</h1>
function renderAuth(mode) {
const isLogin = mode === 'login';
const redirect = getQuery().get('redirect') || '';
const hasSavedJobDraft = redirect === 'post-job' || redirect.startsWith('post-job?');
const authTitle = hasSavedJobDraft ? 'Your job draft is saved' : (isLogin ? 'Welcome back' : 'Join GoHireHumans');
const authSubtitle = hasSavedJobDraft
? 'Sign in or create a free account to review it. Nothing has been posted or charged.'
: (isLogin ? 'Sign in to your account' : (redirect ? 'Create an account to continue your selected task or application.' : 'Request QA, browse services, or offer your skills — free to join.'));
document.getElementById('app').innerHTML = `
<div class="auth2-page">
<div class="auth2-wrap">
<a class="auth2-logo" href="#/" onclick="event.preventDefault();navigate('#/')">${LOGO} GoHireHumans</a>
<div class="auth2-card">
<h1 class="auth2-title">${isLogin ? 'Welcome back' : 'Join GoHireHumans'}</h1>
<div class="auth2-sub">${isLogin ? 'Sign in to your account' : (redirect ? 'Create an account to continue your selected task or application.' : 'Request QA, browse services, or offer your skills — free to join.')}</div>
<h1 class="auth2-title">${authTitle}</h1>
<div class="auth2-sub">${authSubtitle}</div>
${GOOGLE_CLIENT_ID ? `
<div class="auth2-google-wrap" id="google-signin-wrap" hidden>
<div id="google-signin-btn" style="display:flex;justify-content:center"></div>
Expand Down
21 changes: 21 additions & 0 deletions frontend/tests/browser-regression.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,27 @@ test.describe('GoHireHumans public/browser regression suite', () => {
expect(result.afterClear).toBeNull();
});

test('saved job draft context survives switching between login and registration', async ({ page }) => {
await setupDeterministicLocalPage(page);
const redirect = 'post-job?draft_title=Check+ten+AI+claims&draft_description=Return+a+sourced+issue+table';
await page.goto(`/#/login?redirect=${encodeURIComponent(redirect)}`, { waitUntil: 'domcontentloaded' });

await expect(page.locator('.auth2-title')).toHaveText('Your job draft is saved');
await expect(page.locator('.auth2-sub')).toHaveText('Sign in or create a free account to review it. Nothing has been posted or charged.');

await page.locator('.auth2-toggle a').click();
await expect(page).toHaveURL(new RegExp(`#\\/register\\?redirect=${encodeURIComponent(redirect).replace(/[.*+?^${}()|[\\]\\]/g, '\\$&')}$`));
await expect(page.locator('.auth2-title')).toHaveText('Your job draft is saved');
await expect(page.locator('.auth2-sub')).toHaveText('Sign in or create a free account to review it. Nothing has been posted or charged.');

await page.locator('.auth2-toggle a').click();
await expect(page).toHaveURL(new RegExp(`#\\/login\\?redirect=${encodeURIComponent(redirect).replace(/[.*+?^${}()|[\\]\\]/g, '\\$&')}$`));

await page.goto('/#/login?redirect=post-job', { waitUntil: 'domcontentloaded' });
await expect(page.locator('.auth2-title')).toHaveText('Your job draft is saved');
await expect(page.locator('.auth2-sub')).toHaveText('Sign in or create a free account to review it. Nothing has been posted or charged.');
});

test('job posting failure stays visible and retryable', async ({ page }) => {
await setupDeterministicLocalPage(page);
await page.goto('/', { waitUntil: 'domcontentloaded' });
Expand Down
Loading