Merge "byte store" and "action cache" provider options - #20115
Merged
Conversation
huonw
force-pushed
the
huonw/19902-merged-options
branch
from
October 29, 2023 05:17
64087ad to
7a8f14d
Compare
huonw
marked this pull request as ready for review
October 29, 2023 09:48
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces uses of
RemoteCacheProviderOptionswithRemoteStoreOptions(previouslyRemoteOptions): they're very similar, and only separate because they were previously in very different parts of the codebase, but this has changed with #19958.This makes a few additional changes to make the merging smoother:
GetCapabilitiesRequestgRPC request result between the CAS and the remote execution providers, if both were being used with the same address. I thought that optimising one-time (on start-up) requests from 2 to 1 wasn't worth the complexity of plumbing it through these more generic options, but can restore it if it is.This does meant that there's a few options that are seemingly irrelevant to the action cache providers, e.g. "batch API size limit" is meaningless. I think this is fine: I think it's fundamental to supporting multiple providers that there'll be a grab-bag of options, which some providers support and others do not.
The commits are individually reviewable.
(This is one point of #19902.)