fix reapi provider to actually use remote_store_rpc_retries again - #23582
Open
cburroughs wants to merge 1 commit into
Open
fix reapi provider to actually use remote_store_rpc_retries again#23582cburroughs wants to merge 1 commit into
cburroughs wants to merge 1 commit into
Conversation
So I think the history here is: * #6931 retries honored * #11307 Tonic migration; deleted every read of rpc_attempts and used a hardcoded 3 * #13807 Rust 1.57 upgrade. Sort of caught this, but squelched with a _ prefix. * #19827 opendal provider added, did use the field * #20115 Merged byte-store and AC provider options into RemoteStoreOptions: the AC provider now also received a retries value it never read A related bug while here was that the OpenDAL provider would retry N+1 instead of N times.. NOTE: An LLM statically identified this bug while I was trying to make an adjacent change, and generated this fix.
cburroughs
marked this pull request as ready for review
July 29, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I think the history here is:
A related bug while here was that the OpenDAL provider would retry N+1 instead of N times..
NOTE: An LLM statically identified this bug while I was trying to make an adjacent change, and generated this fix.