fix(release): run gates without the removed runner wrapper - #273
Merged
Conversation
scripts/release.sh still invoked $ROOT/runner, which was deleted with the rest of the repo tooling, so 'release.sh gates' failed immediately on the first gate. Run the gates directly, keeping MCP_RUNNER as an override and still preferring ./runner when a checkout has one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(release): run gates without the removed runner wrapper This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./scripts/release.sh gatesfails immediately on currentmain:The script still resolves its command wrapper as
$ROOT/runner, butrunnerwas deleted along with the rest of the repo tooling in8a5ed77. Stage 1 ofdocs/RELEASE.mdis therefore unrunnable, which blocks the whole serialized release — found while actually cutting 0.13.0.Gates now run directly.
MCP_RUNNERstill overrides, and a checkout that does have./runnerstill uses it, so nothing regresses for other layouts.Verified by running the thing that was broken:
./scripts/release.sh gatescompletes green throughpnpm check,pnpm test,pnpm build,pnpm build:bun, the release-contract mocks, andpnpm audit("No known vulnerabilities found").🤖 Generated with Claude Code