fix(release): package without the removed runner wrapper - #274
Merged
Conversation
package-release.sh had the same $ROOT/runner default as release.sh, so the native gate failed right after the keychain was prepared. The mocked contract tests never caught it because test-release.sh passes MCP_RUNNER=env, which masks the missing wrapper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second half of the same breakage as #273, found by running the real native gate rather than the mocks.
scripts/package-release.shcarried the identicalRUNNER=${MCP_RUNNER:-"$ROOT/runner"}default, so./scripts/release.sh nativedied immediately after the Developer ID keychain was prepared:Worth recording why this survived CI and the release-contract tests:
scripts/test-release.shinvokes the packager withMCP_RUNNER=env, which substitutes a working wrapper and masks the missing one. The mocked contract passed on every run while the real signing path was broken — the tests exercised an override, not the default.Same fix as #273: run the build steps directly, keep
MCP_RUNNERas an override, still prefer./runnerwhere a checkout has one.Verified with
./scripts/test-release.sh("Release contract tests passed for v0.13.0"), and the real native gate is the next step in cutting 0.13.0.🤖 Generated with Claude Code