Install > Gaming: Quake (on-demand via the omarchy-quake package) - #7570
Install > Gaming: Quake (on-demand via the omarchy-quake package)#7570ryrobes wants to merge 1 commit into
Conversation
…ackage. The ISO ships only this stub. Install runs omarchy-pkg-add omarchy-quake (vkQuake + launcher + Quickshell plugin from the [omarchy] repo), copies the plugin into ~/.config/omarchy/plugins, enables it, wires the Hyprland rules, and launches the panel. First Play fetches shareware (~18MB); existing Steam/GOG PAKs and the 2021 re-release are auto-discovered. Remove keeps saves unless --purge. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This is really cool. I pinged you on X, but I'll continue with this PR. We were wondering about the license, so with help from AI, this was the response. We have to ensure we don't add anything to the repo which violate any license. Review
|
|
Thanks for flagging these. I addressed each distribution/licensing concern in omarchy-quake v1.6.3:
The focused downloader/layout tests pass, and omarchy-pkgs PR #175 now consumes the pinned v1.6.3 release. |
There was a problem hiding this comment.
Pull request overview
Adds on-demand Quake installation and removal through Omarchy’s gaming menu.
Changes:
- Adds Quake install/remove menu entries.
- Installs the package, shell plugin, Hyprland integration, and launcher.
- Supports removal with optional data purging.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
default/omarchy/omarchy-menu.jsonc |
Adds Quake gaming menu actions. |
bin/omarchy-install-gaming-quake |
Installs and configures Quake integration. |
bin/omarchy-remove-gaming-quake |
Removes Quake with optional data purging. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Adds Install > Gaming > Quake, installed on demand — the ISO ships only this stub.
omarchy-install-gaming-quake:omarchy-pkg-add omarchy-quake(vkQuake + launcher + panel plugin from the[omarchy]repo), copies the Quickshell plugin into~/.config/omarchy/plugins/quake.omarchy(copy, not symlink — the validator forbids symlinks), enables it with a rescan/retry so it doesn't race the shell's plugin scan, wires the Hyprland window rules, and launches the panel. First Play fetches shareware (~18MB); Steam/GOG/re-release data is auto-discovered.omarchy-remove-gaming-quake: drops the package and plugin; saves/shareware stay unless--purge.disabled:on install,when:on remove).One deliberate deviation to review: the installer copies the window rules to
~/.config/hypr/apps/quake-omarchy.luaand appends arequire(...)line to~/.config/hypr/hyprland.lua(with a timestamped backup) since stock configs don't auto-load that directory. If you'd rather ship the rules asdefault/hypr/apps/quake.luain omarchy itself, happy to rework — the keybindings (Super+Shift+Q panel toggle, DM map cycling outside the Quake console for the host) are the part that shouldn't exist without the package installed.Depends on omacom/omarchy-pkgs#175 — draft until
omarchy-quakeis published on edge andomarchy-pkg-add omarchy-quakeverifies on a stock box.preview-gh.mp4