Add omarchy-quake (Quake 1: vkQuake, Omarchy panel, Tailscale deathmatch) - #175
Add omarchy-quake (Quake 1: vkQuake, Omarchy panel, Tailscale deathmatch)#175ryrobes wants to merge 3 commits into
Conversation
…ailscale deathmatch. vkQuake 1.35 (Vulkan, SDL3, native Wayland) built from two pinned GitHub tarballs with four small engine patches (Wayland quit crash, rcon), plus the omarchy-quake launcher, Quickshell plugin, and Hyprland rules under /usr. package() writes nothing to $HOME; the basecamp/omarchy install stub copies and enables the shell plugin after pacman. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Greptile SummaryAdds a locally maintained package for vkQuake with Omarchy desktop integration.
Confidence Score: 4/5The PR should not merge until the package stops advertising the unsupported aarch64 build target. The current recipe still includes aarch64 in its architecture array despite the stated x86_64-only support scope, so repository automation can select an unsupported target. Files Needing Attention: pkgbuilds/omarchy-quake/PKGBUILD
|
| Filename | Overview |
|---|---|
| pkgbuilds/omarchy-quake/PKGBUILD | Adds the complete build and packaging recipe; its architecture declaration remains inconsistent with the package's stated support scope. |
| pkgbuilds/omarchy-quake/.omarchy/package.json | Registers omarchy-quake as a locally maintained catalog package. |
Reviews (2): Last reviewed commit: "Declare opusfile so the Opus codec is bu..." | Re-trigger Greptile
| pkgver=1.6.3 | ||
| pkgrel=1 | ||
| pkgdesc="Quake 1 for Omarchy (vkQuake, shareware fetch, Tailscale deathmatch)" | ||
| arch=('x86_64' 'aarch64') |
There was a problem hiding this comment.
Align the advertised architectures
The arch array schedules this package for the repository's aarch64 build target, while the submitted support scope says it is x86_64-only. Advertising only the architecture actually supported avoids publishing an unverified ARM package.
| arch=('x86_64' 'aarch64') | |
| arch=('x86_64') |
vkQuake compiles Quake/snd_opus.c only when both opus and opusfile are found, and use_codec_opus defaults to auto, so a builder without opusfile silently drops the codec instead of failing. In a clean container makepkg -s installed every declared dependency and meson still reported "Run-time dependency opusfile found: NO"; the packaged engine linked libmpg123, libFLAC and libvorbisfile but no Opus at all, which left the declared opus dependency buying nothing. With opusfile declared, meson finds it and the engine links libopusfile.so.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Re-reviewed at c73234f (1.6.3 + aarch64). Two of the findings from the last pass are resolved, one I fixed and pushed — your branch is now at 66c59ac. The unverified shareware download is fixed, and I checked it against the real mirrors rather than reading the code. 1.6.3 adds One limit worth knowing: the pin protects the download, not a directory that already looks installed.
New, low: a shareware install made by a pre-1.6.3 build has no aarch64 is declared but, as far as anything here shows, never built. I could not settle it: the worker is x86_64 and emulated ARM compilation of vkQuake was not worth the hour. Nothing architecture-specific turned up — vkQuake 1.35's x86 library paths are confined to Windows branches, Separately, the PR body still says "x86_64 only for now", which is what led the greptile comment to read the Two items for the maintainer rather than for you, unchanged from the last pass and both product decisions rather than defects: while hosting, the engine on UDP 26000 and Reviewed by Opus 5 in Claude Code and by Codex at xhigh reasoning. Codex read the same head and agreed on the opusfile mechanism, on the low rating for the environment inheritance, and that the greptile comment's reasoning is stale — though it was pointed at each of those by my prompt, and its independence is not guaranteed, since it runs as the same user and can read this session's own files. Three things it contributed that I had not reasoned about: that ARM is buildable today rather than only after #171, the |
Adds omarchy-quake: Quake 1 for Omarchy — vkQuake 1.35 (Vulkan, SDL3, native Wayland, Hyprland friendly) wrapped in an
omarchy-quakelauncher, a Quickshell panel plugin, and Hyprland window rules. First launch downloads the official shareware (~18MB); existing Steam/GOG PAKs and the 2021 re-release are auto-discovered. Deathmatch over Tailscale or LAN: hosting copies a one-line join command for the other machine.Build notes:
patch(1)and sentinel-checked.package()writes nothing to$HOME. The shell plugin ships as files under/usr/share/omarchy-quake/plugin/; the basecamp/omarchy install stub (companion PR) copies and enables it after pacman./usr/share/licenses/omarchy-quake/.x86_64only for now; software rendering falls back to lavapipe viavulkan-swrast(optdepend).Tested:
makepkgfrom these exact sources, thenpacman -U+ plugin enable + play (single player and Tailscale deathmatch between two machines) on stock Omarchy 4. Fine to leave off thefastring until it has soaked on edge.Companion PR (menu stub + on-demand installer): omacom/omarchy#7570
preview-gh.mp4