chore!: clear deployment state and flag the fork as unaudited - #46
Merged
Conversation
Nothing in this tree is deployed, and the artefacts still said otherwise. - removes the legacy root `networks.json`. It recorded upstream's addresses for contracts this fork no longer matches, so leaving it invited those addresses to be read as the fork's own. When this fork does deploy, the canonical record is `deployments/networks.json` - `dev/verify-contracts.sh` now fails with a clear message instead of feeding `null` addresses into `forge verify-contract` - drops the README deployment address table and states plainly that there are no deployments - reframes the audit list: those audits cover upstream before this work, and do not carry over - adds a warning under the README title that the fork is unaudited, not deployed, and substantially changed BREAKING CHANGE: `networks.json` is removed. Consumers resolving addresses from it were resolving upstream deployments, not this fork's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing in this tree is deployed, and the artefacts still said otherwise.
networks.json(274 lines, 8 contracts x 8 chains). Those are upstream's addresses, for contracts this fork no longer matches after the generateOrder rename, typed errors, poll interface and proof-payload changes. Leaving the file invited them to be read as this fork's own deployments. When this fork does deploy, the canonical record isdeployments/networks.json, landing in docs: monitoring-service terminology, verdict permanence, deployments manifest #41.dev/verify-contracts.shwas the file's only consumer. It now fails with a clear message instead of feedingnulladdresses intoforge verify-contract.BREAKING:
networks.jsonis removed. Any consumer resolving addresses from it was resolving upstream deployments, not this fork's.How to test
Part of #1.