docs: monitoring-service terminology, verdict permanence, deployments manifest - #41
Open
mfw78 wants to merge 1 commit into
Open
docs: monitoring-service terminology, verdict permanence, deployments manifest#41mfw78 wants to merge 1 commit into
mfw78 wants to merge 1 commit into
Conversation
This was referenced Jul 11, 2026
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 03:50
a3af0b8 to
da2512b
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
2 times, most recently
from
July 30, 2026 04:01
ea5d427 to
d822b7d
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 06:59
60a398f to
4e49284
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 06:59
d822b7d to
1befa00
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 07:02
4e49284 to
c14cebe
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 07:02
1befa00 to
1043cdd
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 07:07
c14cebe to
8db0db6
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 07:07
1043cdd to
0104481
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 07:09
8db0db6 to
a353d2b
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
2 times, most recently
from
July 30, 2026 07:14
83539c7 to
9c72493
Compare
mfw78
added a commit
that referenced
this pull request
Jul 30, 2026
Nothing in this tree is deployed, and the artefacts still said otherwise. - **removes the legacy root `networks.json`** (274 lines, 8 contracts x 8 chains). Those are *upstream's* addresses, for contracts this fork no longer matches after the generateOrder rename, typed errors, poll interface and proof-payload changes. Leaving the file invited them to be read as this fork's own deployments. When this fork does deploy, the canonical record is `deployments/networks.json`, landing in #41. - **`dev/verify-contracts.sh`** was the file's only consumer. It now fails with a clear message instead of feeding `null` addresses into `forge verify-contract`. - **drops the README address table** and states plainly that there are no deployments. - **reframes the audit list.** It previously read "The above deployed contracts have been audited by" directly under the address table. Those audits cover upstream before this work, so leaving it unqualified alongside an unaudited warning would have been contradictory. - **adds a warning under the README title** that the fork is unaudited, not deployed, and substantially changed. **BREAKING**: `networks.json` is removed. Any consumer resolving addresses from it was resolving upstream deployments, not this fork's. ## How to test ```sh rg '0x[0-9a-fA-F]{40}' README.md # no addresses left test -f networks.json # gone ./dev/verify-contracts.sh 1 # fails with the no-deployments message ``` Part of #1.
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 07:18
9c72493 to
99bfe4a
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 07:22
1adff10 to
45aafa9
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 07:22
99bfe4a to
2c7570f
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 07:26
45aafa9 to
790f4ad
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 07:26
2c7570f to
47bf1e7
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 07:33
790f4ad to
7be42fc
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
2 times, most recently
from
July 30, 2026 08:23
a1f8a8a to
e343718
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 08:23
7be42fc to
9e8cd3e
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 08:42
e343718 to
7a5a798
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 08:42
9e8cd3e to
5663501
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 09:51
7a5a798 to
a060d1c
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 09:54
2fc05f5 to
5dda0ce
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 09:54
a060d1c to
09f41a3
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 10:24
5dda0ce to
edabf32
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 10:24
09f41a3 to
4ea86b7
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 10:40
edabf32 to
bdd4dd8
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
2 times, most recently
from
July 30, 2026 12:54
7a4d81a to
0cb431a
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
2 times, most recently
from
July 30, 2026 13:07
38f6ba1 to
b851f74
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 13:07
0cb431a to
2c23662
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 13:19
b851f74 to
b469984
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
3 times, most recently
from
July 30, 2026 14:25
f13c656 to
deee630
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
2 times, most recently
from
July 30, 2026 23:43
c2dc973 to
9c527b7
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 23:43
deee630 to
84cb438
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 30, 2026 23:51
9c527b7 to
e36b654
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 30, 2026 23:51
84cb438 to
933737d
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 31, 2026 00:06
e36b654 to
34ef864
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 31, 2026 00:06
933737d to
140abeb
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 31, 2026 00:12
34ef864 to
97120da
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
2 times, most recently
from
July 31, 2026 00:14
49c05c3 to
a2b4d6d
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
2 times, most recently
from
July 31, 2026 04:00
f659bd8 to
429f6ad
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 31, 2026 04:00
a2b4d6d to
3e2f141
Compare
mfw78
force-pushed
the
feat/discovery-interfaces
branch
from
July 31, 2026 05:26
429f6ad to
3d2c877
Compare
mfw78
force-pushed
the
docs/monitoring-service-deployments
branch
from
July 31, 2026 05:26
3e2f141 to
58308d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INVALIDuniformly terminal,NEEDS_INPUTacquisition semantics, theRestrictionoverlay; breaking-changes table extendeddeployments/networks.jsonmanifest (chainId → registry address, deploy block, topic0 set) with schema READMEIssues
Advances #35. The verdict-permanence rows and the
deployments/networks.jsonschema land here, but three of the issue's asks are not finished:docs/architecture.mdL12 reading "off-chain monitoring service (historically called a watch-tower)s", L102 still readsWatch-Tower, andREADME.mdis untouched (5 occurrences)checkOrder", which feat!: separate swap-guard restriction from the generator verdict #38 made false (the guard is applied in the shared_poll), and the L220PollResultsnippet omitsrestriction; the changelog at L554 still describes swap-guard restriction as anINVALIDverdictnetworks.jsoncarries an emptynetworksobject, so no chainId -> address / deployBlock / topic0 entry is actually publishedCloses #15 - the issue is superseded by the discovery set as a whole (#36 spec, #37-#41 implementation), not by any single PR in it; this is the last of that set. The delivered design differs from the issue's literal proposal: there is no
typeId()orversion()getter,descriptorURI()returnsstring[]on a sidecar rather thanstringonIConditionalOrderGenerator, andBaseConditionalOrderdeliberately does not default them. The supersession is recorded in the design note on #15.Part of #1.