Skip to content

fix: upgrade Octocrab within the declared MSRV - #37

Merged
pierrick-fonquerne merged 1 commit into
mainfrom
fix/octocrab-msrv
Aug 12, 2026
Merged

fix: upgrade Octocrab within the declared MSRV#37
pierrick-fonquerne merged 1 commit into
mainfrom
fix/octocrab-msrv

Conversation

@pierrick-fonquerne

Copy link
Copy Markdown
Contributor

Summary

  • upgrade Octocrab from 0.44.1 to 0.47.1 with only the GitHub client, Rustls, and timeout features
  • configure Cargo dependency updates to prefer versions compatible with the declared Rust 1.88 MSRV
  • document why 0.47.1 is the newest safe and fleet-portable target
  • update quinn-proto to 0.11.16 to remove RUSTSEC-2026-0185
  • add a policy test that protects the resolver and feature choices

Root cause

Dependabot PR #32 proposed Octocrab 0.54.1. Its build dependency chain selected cargo-platform 0.3.3, which requires Rust 1.91, while this repository declares and tests Rust 1.88.

Cargo's MSRV-aware fallback can select the compatible cargo-platform 0.3.2, but Octocrab 0.48+ also requires a JWT crypto backend that this workflow-token client does not use. The RustCrypto option introduces the unpatched RUSTSEC-2023-0071 advisory; the AWS-LC option requires an extra native toolchain and fails on a clean Windows host without NASM. Octocrab 0.47.1 avoids both problems and supports Rust 1.73.

The broader fleet MSRV decision remains tracked in #28.

Validation

  • cargo +1.88.0 fmt --all -- --check
  • cargo +1.88.0 clippy --workspace --all-targets --all-features -- -D warnings
  • cargo +1.88.0 test --workspace --all-features --no-fail-fast (72 tests)
  • cargo +1.88.0 check --workspace --all-features --all-targets
  • cargo +1.88.0 update -p octocrab (0 packages changed)
  • cargo audit (0 vulnerabilities)
  • git diff --check

Closes #29.

Supersedes #32 once merged.

@pierrick-fonquerne

Copy link
Copy Markdown
Contributor Author

Final review: no findings.

Validated the exact head SHA 0e945bbf8167db754557aa450306bc7f3eacb0ce with the Rust 1.88 format, Clippy, test, check, resolver-stability, and audit commands documented in the PR. All four GitHub CI jobs passed. The end-to-end smoke test in nubster-opensources/lightshuttle#318 also passed both reusable jobs and successfully published the team review comment through the upgraded Octocrab client.

@pierrick-fonquerne
pierrick-fonquerne marked this pull request as ready for review August 12, 2026 22:09
@pierrick-fonquerne
pierrick-fonquerne merged commit b21ebff into main Aug 12, 2026
4 checks passed
@pierrick-fonquerne
pierrick-fonquerne deleted the fix/octocrab-msrv branch August 12, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deps: unblock the octocrab upgrade held back by a transitive rustc 1.91 requirement

1 participant