fix: upgrade Octocrab within the declared MSRV - #37
Merged
Conversation
Contributor
Author
|
Final review: no findings. Validated the exact head SHA |
pierrick-fonquerne
marked this pull request as ready for review
August 12, 2026 22:09
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quinn-prototo 0.11.16 to remove RUSTSEC-2026-0185Root cause
Dependabot PR #32 proposed Octocrab 0.54.1. Its build dependency chain selected
cargo-platform0.3.3, which requires Rust 1.91, while this repository declares and tests Rust 1.88.Cargo's MSRV-aware fallback can select the compatible
cargo-platform0.3.2, but Octocrab 0.48+ also requires a JWT crypto backend that this workflow-token client does not use. The RustCrypto option introduces the unpatched RUSTSEC-2023-0071 advisory; the AWS-LC option requires an extra native toolchain and fails on a clean Windows host without NASM. Octocrab 0.47.1 avoids both problems and supports Rust 1.73.The broader fleet MSRV decision remains tracked in #28.
Validation
cargo +1.88.0 fmt --all -- --checkcargo +1.88.0 clippy --workspace --all-targets --all-features -- -D warningscargo +1.88.0 test --workspace --all-features --no-fail-fast(72 tests)cargo +1.88.0 check --workspace --all-features --all-targetscargo +1.88.0 update -p octocrab(0 packages changed)cargo audit(0 vulnerabilities)git diff --checkCloses #29.
Supersedes #32 once merged.