Skip to content

stream: validate broadcast writer writev chunks #63300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trivikr wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

stream: validate broadcast writer writev chunks #63300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/internal/streams/iter/broadcast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,9 @@ class BroadcastWriter {
}

writev(chunks, options) {
if (!ArrayIsArray(chunks)) {
throw new ERR_INVALID_ARG_TYPE('chunks', 'Array', chunks);
}
// Fast path: no signal, writer open, buffer has space
if (this.#canUseWriteFastPath(options)) {
const converted = convertChunks(chunks);
Expand Down Expand Up @@ -522,6 +525,9 @@ class BroadcastWriter {
}

writevSync(chunks) {
if (!ArrayIsArray(chunks)) {
throw new ERR_INVALID_ARG_TYPE('chunks', 'Array', chunks);
}
if (this.#isClosedOrAborted()) return false;
if (!this.#broadcast[kCanWrite]()) return false;
const converted = convertChunks(chunks);
Expand Down
10 changes: 10 additions & 0 deletions test/parallel/test-stream-iter-validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,16 @@ assert.throws(() => broadcast({ highWaterMark: Number.MAX_SAFE_INTEGER + 1 }),
assert.throws(() => broadcast({ signal: {} }), { code: 'ERR_INVALID_ARG_TYPE' });
assert.throws(() => broadcast({ backpressure: 'bad' }), { code: 'ERR_INVALID_ARG_VALUE' });

// BroadcastWriter.writev requires array
{
const { writer } = broadcast();
assert.throws(() => writer.writev('bad'), { code: 'ERR_INVALID_ARG_TYPE' });
assert.throws(() => writer.writev(42), { code: 'ERR_INVALID_ARG_TYPE' });
assert.throws(() => writer.writevSync('bad'), { code: 'ERR_INVALID_ARG_TYPE' });
assert.throws(() => writer.writevSync(42), { code: 'ERR_INVALID_ARG_TYPE' });
writer.endSync();
}

// Broadcast.from rejects non-iterable input
assert.throws(() => Broadcast.from(42), { code: 'ERR_INVALID_ARG_TYPE' });
assert.throws(() => Broadcast.from('bad'), { code: 'ERR_INVALID_ARG_TYPE' });
Expand Down
Loading