Skip to content

stream: validate broadcast writer writev chunks#63300

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:stream-iter-broadcast-writev
Open

stream: validate broadcast writer writev chunks#63300
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:stream-iter-broadcast-writev

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented May 14, 2026

Fixes BroadcastWriter writev() and writevSync() input validation so
non-array chunks values throw ERR_INVALID_ARG_TYPE before reaching
convertChunks().

Previously, writer.writev('abc') treated the string as array-like and wrote
abc, while writer.writev(42) resolved as an empty batch.

Fixes: #63299


Assisted-by: openai:gpt-5.5

Validate BroadcastWriter writev() and writevSync() inputs before
converting chunks so non-array values throw ERR_INVALID_ARG_TYPE.

Fixes: nodejs#63299

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels May 14, 2026
@trivikr trivikr self-assigned this May 14, 2026
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (c24e552) to head (11dc64d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63300      +/-   ##
==========================================
- Coverage   90.05%   90.04%   -0.01%     
==========================================
  Files         714      714              
  Lines      225247   225253       +6     
  Branches    42578    42581       +3     
==========================================
- Hits       202842   202830      -12     
- Misses      14181    14220      +39     
+ Partials     8224     8203      -21     
Files with missing lines Coverage Δ
lib/internal/streams/iter/broadcast.js 84.76% <100.00%> (+0.11%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stream/iter: BroadcastWriter writev methods accept non-sequence chunks

3 participants