Grant dev Terraform CI access to Key Vault#83
Merged
Conversation
Terraform Plan (
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69a8c91c14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+197
to
+202
| resource "azurerm_key_vault_access_policy" "ci_deployers" { | ||
| for_each = var.ci_deployer_object_ids | ||
|
|
||
| key_vault_id = azurerm_key_vault.kv.id | ||
| tenant_id = data.azurerm_client_config.current.tenant_id | ||
| object_id = each.value |
There was a problem hiding this comment.
For the existing dev vault state that this change targets, the CI identity still has no data-plane permission when the workflow invokes its normal terraform apply -auto-approve (.github/workflows/infrastructure.yml:222-227). Terraform refreshes the tracked azurerm_key_vault_secret resources before it can create this policy, so those reads receive 403 and the apply exits before this resource or its depends_on edges can take effect. Consequently, merging this commit alone leaves the failed CI run unable to apply; the policy must be granted through a bootstrap path that does not require reading the existing secrets first.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Validation
Follow-up