Bootstrap dev Key Vault access before Terraform apply#84
Merged
Conversation
Terraform Plan (
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bded32ea96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+227
to
+230
| az keyvault set-policy \ | ||
| --name nl-dev-convolens-kv \ | ||
| --object-id "$DEPLOYER_OBJECT_ID" \ | ||
| --secret-permissions get list set delete purge recover |
There was a problem hiding this comment.
On the first dev deployment (and after the documented terraform destroy), nl-dev-convolens-kv does not yet exist; the dev Terraform configuration is what creates it. This unconditional az keyvault set-policy therefore exits nonzero before Terraform Init/Apply can create the vault, preventing CI from provisioning or recreating the environment. Guard the command for a missing vault, or perform this bootstrap only after the vault is known to exist.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Validation