Skip to content

fix: move canary publish to CD for npm trusted publishing #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spuppo-mux wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −8
Open

fix: move canary publish to CD for npm trusted publishing #1339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eea1ab
fix(ci): publish canaries from CD workflow to satisfy npm trusted pub…
spuppo-mux Jun 25, 2026
c07b550
refactor: removed comments
spuppo-mux Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ jobs:
- name: Publish
if: ${{ steps.release.outputs.releases_created == 'true' }}
run: npm exec -c publish-packages
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: 'Get message'
if: ${{ steps.release.outputs.releases_created == 'true' }}
Expand All @@ -91,3 +89,30 @@ jobs:
SLACK_USERNAME: Mux Elements
SLACK_ICON: https://avatars.githubusercontent.com/muxinc?size=48
SLACK_FOOTER: ''

canary:
# Only publish canaries from main, and never on the Release Please commit
# (that path publishes the real release via `release` above).
if: ${{ github.ref == 'refs/heads/main' && github.event.commits[0].author.name != 'github-actions[bot]' }}

runs-on: ubuntu-latest
environment: production
permissions:
id-token: write

steps:
- uses: actions/checkout@v4
- name: read node version from the .nvmrc file
run: echo ::set-output name=NODE_VERSION::$(cat .nvmrc)
shell: bash
id: nvmrc
- uses: actions/setup-node@v4
with:
node-version: ${{steps.nvmrc.outputs.NODE_VERSION}}
# required so npm can publish below
registry-url: 'https://registry.npmjs.org'
cache: npm
- run: npm ci
- run: npm run clean
- run: npm run build:packages
- run: npx --yes -w packages wet-run@1.2.5 release prerelease --prerelease canary --provenance --log-level verbose
6 changes: 0 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ jobs:

runs-on: ubuntu-latest
timeout-minutes: 15
permissions:
id-token: write

steps:
- uses: actions/checkout@v4
Expand All @@ -32,10 +30,6 @@ jobs:
- run: npm ci
- run: npm run clean
- run: npm run build:packages
- run: npx --yes -w packages wet-run@1.2.5 release prerelease --prerelease canary --provenance --log-level verbose
if: ${{ github.ref == 'refs/heads/main' }}
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

lint:
# Don't run if the CI is triggered by Release Please
Expand Down
Loading