fix: move canary publish to CD for npm trusted publishing#1339
Open
spuppo-mux wants to merge 2 commits into
Open
fix: move canary publish to CD for npm trusted publishing#1339spuppo-mux wants to merge 2 commits into
spuppo-mux wants to merge 2 commits into
Conversation
|
@spuppo-mux is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Canary publishes have been failing on every push to
main(Example). Doing a similar approach to what we did for media chrome. Moved (created) canary step to cd.yml. Also removed unused token.Note
Medium Risk
Touches production deployment workflows and npm publish paths; misconfigured gates could skip canaries or publish on the wrong commits, but application/runtime code is unchanged.
Overview
Canary npm publishes are moved out of
ci.ymlinto a dedicatedcanaryjob incd.yml, matching the media-chrome approach so publishes can use npm trusted publishing (OIDC viaid-token: writeand theproductionenvironment) instead of failing with token-based auth.The CI
buildjob no longer runswet-runprerelease or requestsid-tokenpermissions—it only installs, cleans, and builds packages. The new CD job runs onmainfor non–Release Please commits (github-actions[bot]excluded), then ci → clean → build →wet-runcanary prerelease with provenance.The release
Publishstep in CD also drops the unusedNODE_AUTH_TOKENenv var, aligning stable releases with the same trusted-publishing setup.Reviewed by Cursor Bugbot for commit c07b550. Bugbot is set up for automated code reviews on this repo. Configure here.