Skip to content

Fix path traversal detection on Windows in validateDestinationPath #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ConnorQi01 wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −1
Open

Fix path traversal detection on Windows in validateDestinationPath #2714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42eac4a
Fix path traversal detection on Windows in validateDestinationPath
ConnorQi01 Jun 12, 2026
a4725d2
Skip installPods enhanced environment test on non-macOS platforms
ConnorQi01 Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/extension/networkInspector/certificateProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ export class CertificateProvider {
}

private validateDestinationPath(destination: string, os: ClientOS): void {
if (destination.split(/[\\/]+/).includes("..")) {
if (destination.split(path.sep).includes("..")) {
throw new Error(`Path traversal not allowed in destination: ${destination}`);
}

Expand Down
3 changes: 3 additions & 0 deletions test/extension/commands/installPods.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,9 @@ suite("installPodsCommand", function () {

suite("Enhanced environment", function () {
test("should inject Ruby and CocoaPods paths and default shell and locale values", function () {
if (process.platform !== "darwin") {
this.skip();
}
const homeDir = "/Users/test-user";
const originalEnv = {
PATH: process.env.PATH,
Expand Down