Fix path traversal detection on Windows in validateDestinationPath#2714
Open
ConnorQi01 wants to merge 2 commits into
Open
Fix path traversal detection on Windows in validateDestinationPath#2714ConnorQi01 wants to merge 2 commits into
ConnorQi01 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two test failures on Windows caused by macOS-specific assumptions in the test suite.
Proposed Changes
Fix 1:
validateDestinationPathpath traversal detection (Closes #2713)destination.split(/[\/]+/)fails to tokenize Windows backslash paths correctly — the entire path is returned as one token, so..is never detecteddestination.split(path.sep)for platform-correct splittingFix 2:
installPodsenhanced environment test (Closes #2715):as PATH separator (macOS convention) and runs on all platformsos.platform() !== 'darwin'this.skip()Test Plan
npm test: 218 passing, 0 failing, 1 pending (installPods skipped on Windows)