[azure-core-cpp, azure-identity-cpp] Update to latest version by azure-sdk · Pull Request #17142 · microsoft/vcpkg

azure-sdk · 2021-04-07T23:01:22Z

Update vcpkg ports for Azure SDK release. This release may contain multiple ports.

## 1.0.0-beta.8 (2021-04-07) ### New Features - Added `Azure::Core::Url::GetScheme()`. - Added `Azure::Core::Context::TryGetValue()`. - Added `Azure::Core::Context::GetDeadline()`. - Added `Azure::Core::Credentials::TokenCredentialOptions`. - Added useful fields to the `Azure::Core::RequestFailedException` class such as `StatusCode`, `ReasonPhrase`, and the `RawResponse`, for better diagnosis of errors. ### Breaking Changes - Simplified the `Response<T>` API surface to expose two public fields with direct access: `T Value` and a `unique_ptr` to an `Azure::Core::Http::RawResponse`. - Renamed `Azure::Nullable<T>::GetValue()` to `Value()`. - Removed from `Azure::Core::Http::Request`: - `SetUploadChunkSize()`. - `GetHTTPMessagePreBody()`. - `GetUploadChunkSize()`. - `GetHeadersAsString()`. - Changes to `Azure::Core::Http::RawResponse`: - Removed `SetHeader(std::string const& header)` - Removed `SetHeader(uint8_t const* const first, uint8_t const* const last)`. - Removed `GetMajorVersion()`. - Removed `GetMinorVersion()`. - Renamed `GetBodyStream()` to `ExtractBodyStream()`. - Changes to `Azure::Core::Context`: - Removed `Get()` and `HasKey()` in favor of a new method `TryGetValue()`. - Changed input parameter type of `WithDeadline()` to `Azure::DateTime`. - Removed `Azure::Core::PackageVersion`. - Removed from `Azure::Core::Http::Policies` namespace: `HttpPolicyOrder`, `TransportPolicy`, `RetryPolicy`, `RequestIdPolicy`, `TelemetryPolicy`, `BearerTokenAuthenticationPolicy`, `LogPolicy`. - Removed `AppendQueryParameters()`, `GetUrlWithoutQuery()` and `GetUrlAuthorityWithScheme()` from `Azure::Core::Url`. - Changed the `Azure::Core::Http::HttpMethod` regular enum into an extensible enum class and removed the `HttpMethodToString()` helper method. - Introduced `Azure::Core::Context::Key` class which takes place of `std::string` used for `Azure::Core::Context` keys previously. - Changed the casing of `SSL` in API names to `Ssl`: - Renamed type `Azure::Core::Http::CurlTransportSSLOptions` to `CurlTransportSslOptions`. - Renamed member `Azure::Core::Http::CurlTransportOptions::SSLOptions` to `SslOptions`. - Renamed member `Azure::Core::Http::CurlTransportOptions::SSLVerifyPeer` to `SslVerifyPeer`. ### Other changes and Improvements - Moved `Azure::Core::Http::Request` to its own header file from `http.hpp` to `inc/azure/core/http/raw_response.hpp`. - Moved `Azure::Core::Http::HttpStatusCode` to its own header file from `http.hpp` to `inc/azure/core/http/http_status_code.hpp`.

## 1.0.0-beta.5 (2021-04-07) ### New Features - Add Active Directory Federation Service (ADFS) support to `ClientSecretCredential`. ### Breaking Changes - Removed `Azure::Identity::PackageVersion`.

ahsonkhan

@Jinming-Hu use the same branch name (and PR name) for the storage package releases

autoantwort · 2021-04-08T01:24:43Z

So this should be merged into vcpkg and is not spam?

Jinming-Hu · 2021-04-08T02:06:41Z

We should create this kind of PR as draft next time.

NancyLi1013 · 2021-04-08T02:15:13Z

Hi @ahsonkhan

Thanks for your PR.

azure-storage-common-cpp failed with the following errors:

D:\buildtrees\azure-storage-common-cpp\src\0.0-beta.9-fd2c305c02.clean\sdk\storage\azure-storage-common\src\storage_credential.cpp(99): error C2248: 'Azure::Core::Url::AppendQueryParameters': cannot access private member declared in class 'Azure::Core::Url'
D:\installed\x86-windows\include\azure/core/url.hpp(67): note: see declaration of 'Azure::Core::Url::AppendQueryParameters'
D:\installed\x86-windows\include\azure/core/url.hpp(46): note: see declaration of 'Azure::Core::Url'

Could you please look into this?

ahsonkhan · 2021-04-08T03:41:36Z

So this should be merged into vcpkg and is not spam?

Yes, it is intended to be merged. We will no longer open non-draft PRs that are just for tests, and minimize/limit even the draft PRs that are open for testing (ideally just one - #17119).

We should create this kind of PR as draft next time.

Why? We intend to publish the updated versions to the packages and merge this PR.

ahsonkhan · 2021-04-08T03:43:22Z

Could you please look into this?

Thanks @NancyLi1013 - we will add a commit to this PR to update the versions of the azure-storage-* packages, that are built on top of the changes to azure-core-cpp soon (next week) and that should address the the error.

Edit: The update to fix this PR will come next week

ahsonkhan · 2021-04-08T03:52:46Z

@NancyLi1013 can you help me understand what format you prefer the PR titles to be named as (both for new packages, and newer versions)? Is there a set guideline on PR titles? Our PR titles are generated and our CI/CD infra relies on it when adding new commits. If you let us know what format you prefer the name to be, we can setup the PRs to always be opened with the expected name and avoid having the title be renamed.

Its possible that a PR title rename after the PR is opened causes some issues in our infra (I will find out and confirm if this is an issue from our infra team).

Just wanted to give you a heads up and understand the rationale for the title change. We may need to leave PR titles as they were, in the future.

NancyLi1013 · 2021-04-08T08:30:29Z

@ahsonkhan Thanks for your so detailed information about PR titles.

Generally, we prefer to rename the titles as follows:

For new ports, the title like this [PortName] Add new port
For update ports, the title like this [PortName] Update to ***(version or commits)
For bugs or improvement, the title like this [PortName] Fix ***(describe the issue simply)
For vcpkg issue, the title like this [vcpkg] ***(describe what issue you will fix simply)

But currently, there is no document about PR titles.

ahsonkhan · 2021-04-13T00:35:53Z

FYI @RickWinter

## 12.0.0-beta.10 (2021-04-16) ### New Features - Added server timeout support. - Added `PagedResponse<T>` for returning paginated collections. ### Breaking Changes - Removed `Azure::Storage::Common::PackageVersion`. - Moved `ReliableStream` to internal namespace. - Removed `HttpGetterInfo` and `HTTPGetter` from the `Azure::Storage` namespace.

## 12.0.0-beta.10 (2021-04-16) ### Breaking Changes - Removed `Azure::Storage::Blobs::PackageVersion`. - Renamed `GetUserDelegationKeyOptions::startsOn` to `StartsOn`. - Replaced all paginated collection functions that have the SinglePage suffix with pageable functions returning a `PagedResponse<T>`-derived type. The options are also renamed accordingly. - `BlobServiceClient::ListBlobContainers()`. - `BlobServiceClient::FindBlobsByTags()`. - `BlobContainerClinet::ListBlobs()`. - `BlobContainerClient::ListBlobsByHierarchy()`. - `PageBlobClient::GetPageRanges()`. - `PageBlobClient::GetPageRangesDiff()`. - `PageBlobClient::GetManagedDiskPageRangesDiff()`. - Renamed `FilterBlobItem` to `TaggedBlobItem`. - `FindBlobsByTags()` now returns `FindBlobsByTagsPagedResponse` and the field `FindBlobsByTagsSinglePageResult::Items` was renamed to `FindBlobsByTagsPagedResponse::TaggedBlobs`.

## 12.0.0-beta.10 (2021-04-16) ### Breaking Changes - Removed `Azure::Storage::Files::DataLake::PackageVersion`. - Renamed `GetUserDelegationKeyOptions::startsOn` to `StartsOn`. - Replaced all paginated collection functions that have the SinglePage suffix with pageable functions returning a `PagedResponse<T>`-derived type. The options are also renamed accordingly. - `DataLakeServiceClient::ListFileSystems()`. - `DataLakeFileSystemClient::ListPaths()`. - `DataLakeDirectoryClient::ListPaths()`. - Removed `DataLakePathClient::SetAccessControlListRecursiveSinglePage()`, `UpdateAccessControlListRecursiveSinglePage()` and `RemoveAccessControlListRecursiveSinglePage()`. ### Bug Fixes - Rename functions always fail because `/` was left out in the renamed source path.

## 12.0.0-beta.10 (2021-04-16) ### Breaking Changes - Removed `Azure::Storage::Files::Shares::PackageVersion`. - Renamed `GetUserDelegationKeyOptions::startsOn` to `StartsOn`. - Removed `ShareClient::ListFilesAndDirectories()`. - Replaced all paginated collection functions that have the SinglePage suffix with pageable functions returning a `PagedResponse<T>`-derived type. The options are also renamed accordingly. - `ShareServiceClient::ListShares()`. - `ShareDirectoryClient::ListFilesAndDirectories()`. - `ShareDirectoryClient::ListHandles()`. - `ShareFileClient::ListHandles()`. - Removed `ShareDirectoryClient::ForceCloseAllHandlesSinglePage()` and `ShareFileClient::ForceCloseAllHandlesSinglePage()`.

…ile.

…-overwrite-version'

ras0219-msft · 2021-04-16T23:57:18Z

LGTM, thanks!

[azure-core-cpp, azure-identity-cpp] Update to latest version (microsoft#17142)

azure-sdk added 2 commits April 7, 2021 23:01

[azure-identity-cpp] Update to 1.0.0-beta.5

0b57687

## 1.0.0-beta.5 (2021-04-07) ### New Features - Add Active Directory Federation Service (ADFS) support to `ClientSecretCredential`. ### Breaking Changes - Removed `Azure::Identity::PackageVersion`.

ahsonkhan approved these changes Apr 8, 2021

View reviewed changes

ahsonkhan mentioned this pull request Apr 8, 2021

[azure-security-keyvault-*] Add new ports #17143

Merged

JonLiu1993 assigned NancyLi1013 Apr 8, 2021

NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 8, 2021

NancyLi1013 approved these changes Apr 8, 2021

View reviewed changes

NancyLi1013 added the requires:author-response label Apr 8, 2021

NancyLi1013 changed the title ~~Azure SDK Apr Release~~ [azure-core-cpp, azure-identity-cpp] Update to latest version Apr 8, 2021

Jinming-Hu mentioned this pull request Apr 10, 2021

Change the title of vcpkg PR created by CI Azure/azure-sdk-for-cpp#2100

Closed

azure-sdk and others added 6 commits April 16, 2021 09:37

Update vcpkg ports to use a manifest json file instead of a CONTROL f…

ccdfae8

…ile.

Update git tree sha versions using the command 'x-add-version --all -…

342f368

…-overwrite-version'

ahsonkhan mentioned this pull request Apr 16, 2021

Update vcpkg ports to use a manifest json file instead of a CONTROL file. Azure/azure-sdk-for-cpp#2132

Merged

ras0219-msft merged commit 8a62e59 into microsoft:master Apr 16, 2021

ahsonkhan deleted the azure-sdk-for-cpp-april-2021 branch April 16, 2021 23:57

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Apr 17, 2021

Merge pull request #592 from microsoft/master

fd9e9e9

[azure-core-cpp, azure-identity-cpp] Update to latest version (microsoft#17142)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[azure-core-cpp, azure-identity-cpp] Update to latest version#17142

[azure-core-cpp, azure-identity-cpp] Update to latest version#17142
ras0219-msft merged 8 commits into
microsoft:masterfrom
azure-sdk:azure-sdk-for-cpp-april-2021

azure-sdk commented Apr 7, 2021

Uh oh!

ahsonkhan left a comment •

edited

Loading

Uh oh!

autoantwort commented Apr 8, 2021

Uh oh!

Jinming-Hu commented Apr 8, 2021

Uh oh!

NancyLi1013 commented Apr 8, 2021

Uh oh!

ahsonkhan commented Apr 8, 2021

Uh oh!

ahsonkhan commented Apr 8, 2021 •

edited

Loading

Uh oh!

ahsonkhan commented Apr 8, 2021 •

edited

Loading

Uh oh!

NancyLi1013 commented Apr 8, 2021

Uh oh!

ahsonkhan commented Apr 13, 2021

Uh oh!

ras0219-msft commented Apr 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

azure-sdk commented Apr 7, 2021

Uh oh!

ahsonkhan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

autoantwort commented Apr 8, 2021

Uh oh!

Jinming-Hu commented Apr 8, 2021

Uh oh!

NancyLi1013 commented Apr 8, 2021

Uh oh!

ahsonkhan commented Apr 8, 2021

Uh oh!

ahsonkhan commented Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahsonkhan commented Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Apr 8, 2021

Uh oh!

ahsonkhan commented Apr 13, 2021

Uh oh!

ras0219-msft commented Apr 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ahsonkhan left a comment •

edited

Loading

ahsonkhan commented Apr 8, 2021 •

edited

Loading

ahsonkhan commented Apr 8, 2021 •

edited

Loading