Skip to content

Serialize FFI tests that share panic state #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −3
Draft

Serialize FFI tests that share panic state #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba369c0
Initial plan
Copilot Aug 14, 2026
8926c29
test: serialize FFI tests with global poison state
Copilot Aug 14, 2026
480f580
test: remove rand intn flaky comparisons
Copilot Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/interpreter/cases/builtins/numbers/intn.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,16 @@ cases:

results = [
x == z[0],
x != y,
x != a,
x >= 0,
x < 50000,
y >= 0,
y < 50000,
a >= 0,
a < 25000,
rand.intn("b", 0)
]
query: data.test.results
want_result: [true, true, true, 0]
want_result: [true, true, true, true, true, true, true, 0]

- note: undefined
data: {}
Expand Down
2 changes: 2 additions & 0 deletions xtask/src/tasks/bindings/ffi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ impl TestFfiCommand {
}
test_args.push(OsString::from("--features"));
test_args.push(OsString::from("contention_checks"));
test_args.push(OsString::from("--"));
test_args.push(OsString::from("--test-threads=1"));
run_cargo_step(
&ffi_dir,
"cargo test --features contention_checks (bindings/ffi)",
Expand Down
Loading